Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 2, 2024

What do these changes do?

Bumped dynamic-sidecar's health check's start-period to 180 seconds.
Removed --verbose flags which reduced by ~3 orders of magnitude the speed of chmod and chown commands.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 2, 2024
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Dec 2, 2024
@GitHK GitHK marked this pull request as ready for review December 2, 2024 18:21
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (f56acf6) to head (3ea2dea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6886      +/-   ##
==========================================
+ Coverage   88.31%   89.75%   +1.43%     
==========================================
  Files        1553       73    -1480     
  Lines       61193     3172   -58021     
  Branches     2095        0    -2095     
==========================================
- Hits        54043     2847   -51196     
+ Misses       6818      325    -6493     
+ Partials      332        0     -332     
Flag Coverage Δ
integrationtests 59.86% <ø> (-5.19%) ⬇️
unittests 88.80% <ø> (+2.30%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver ∅ <ø> (∅)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56acf6...3ea2dea. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's more than 3 right? and all the time.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK enabled auto-merge (squash) December 3, 2024 07:27
@GitHK GitHK added this to the Event Horizon milestone Dec 3, 2024
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

@GitHK GitHK merged commit 7b5cba8 into ITISFoundation:master Dec 4, 2024
87 of 88 checks passed
@GitHK GitHK deleted the pr-osparc-sidecar-no-permission-changes branch December 4, 2024 23:43
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:dynamic-sidecar dynamic-sidecar service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants