Skip to content

🐛 Making dy-sidecar start faster when volumes contain data #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2024
Merged

🐛 Making dy-sidecar start faster when volumes contain data #6886

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a7afff
remove verbose for speed
Dec 2, 2024
6bdfd6a
bumped time
Dec 2, 2024
58e28a1
Merge branch 'master' into pr-osparc-sidecar-no-permission-changes
GitHK Dec 3, 2024
24823f7
raiseed timeout
GitHK Dec 3, 2024
3ea2dea
Merge branch 'master' into pr-osparc-sidecar-no-permission-changes
odeimaiz Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/dynamic-sidecar/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ RUN chmod +x services/dynamic-sidecar/docker/*.sh
HEALTHCHECK \
--interval=10s \
--timeout=5s \
--start-period=30s \
--start-period=60s \
--start-interval=1s \
--retries=5 \
CMD ["python3", "services/dynamic-sidecar/docker/healthcheck.py", "http://localhost:8000/health"]
Expand Down
4 changes: 2 additions & 2 deletions services/dynamic-sidecar/docker/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ fi
# Change ownership of volumes mount directory
# directories are empty at this point
# each individual subdirectory is a unique volume
chown --verbose --recursive "$SC_USER_NAME":"$GROUPNAME" "${DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR}"
chown --recursive "$SC_USER_NAME":"$GROUPNAME" "${DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR}"
# Allow owner and group to edit write and execute
# files from all the subdirectories
# When the service access files downloaded by the dynamic-sidecar
# it uses group permissions
chmod --verbose --recursive 774 "${DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR}"
chmod --recursive 774 "${DYNAMIC_SIDECAR_DY_VOLUMES_MOUNT_DIR}"

echo "$INFO Starting $* ..."
echo " $SC_USER_NAME rights : $(id "$SC_USER_NAME")"
Expand Down
Loading