🐛 Fixes web-api: issues on groups entrypoints #6939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
the
a:webserver
pcrespov
changed the title
pcrespov
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66 and
sanderegg
as code owners
giancarloromeo
approved these changes
Dec 11, 2024
GitHK
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6939 +/- ##
==========================================
- Coverage 75.57% 72.14% -3.43%
==========================================
Files 1082 765 -317
Lines 44715 34509 -10206
Branches 909 262 -647
==========================================
- Hits 33794 24898 -8896
+ Misses 10788 9551 -1237
+ Partials 133 60 -73
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
bisgaard-itis
approved these changes
Dec 11, 2024
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Very nice. Thanks a lot. Just a minor suggestion from my side
services/web/server/tests/unit/with_dbs/01/groups/test_groups_handlers_crud.py
Show resolved
Hide resolved
pcrespov
force-pushed
the
is1779/fixes-master
branch
from
739fad7 to
85ac82e
Compare
1 task
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR addresses issues currently present in the master deployment:
add_user_to_groupby properly handlinguserName.gidanduidin the web API OpenAPI Specification (OAS), which is currently blocking front-end operations in master.Related issue/s
How to test
test_list_user_groups_and_try_modify_organizationsDev-ops
None