Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 12, 2025

What do these changes do?

ReDoc

Our product contains a UI configuration fully managed by the front-end, with the backend currently serving solely as storage. At present, this configuration is read-only; however, we plan to develop a front-end widget enabling product owner (PO) users to modify it, thereby granting write access in the future. For now, @odeimaiz will handle manual configuration.

  • ✨ web-api API: front-end can read product's ui config
    • GET /products/current/ui accessible to all active >=users (e.g. not guests)
    • For more details please check products section in the openapi specs (click badge above)
  • 🗃️ new products.ui column for front-end free-json
  • ♻️ cleanup models and updated mocks

NOTE: I will follow up this PR with a maintenance PR to upgrade db engine and skelepton on the web-server's products domain.

Related issue/s

  • part of ITISFoundation/private-issues#7

How to test

Driving tests

cd services/web/server
make install-dev
pytest -vv tests/unit**/test_*product*.py
pytest -vv tests/unit/with_dbs/04/products/test_products_handlers.py:test_get_current_product_ui

Dev-ops

  • 🚨 Needs configuration of products.ui column

@pcrespov pcrespov self-assigned this Feb 12, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:database associated to postgres service and postgres-database package labels Feb 12, 2025
@pcrespov pcrespov force-pushed the is1822/product-ui-config branch from 9115fae to ed27bfc Compare February 12, 2025 13:48
@pcrespov pcrespov marked this pull request as ready for review February 12, 2025 13:48
@pcrespov pcrespov added this to the Singularity milestone Feb 12, 2025
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks!!!

@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (c53197d) to head (b46b894).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7217      +/-   ##
==========================================
+ Coverage   87.02%   87.03%   +0.01%     
==========================================
  Files        1654     1654              
  Lines       64435    64468      +33     
  Branches     1095     1095              
==========================================
+ Hits        56075    56111      +36     
+ Misses       8047     8044       -3     
  Partials      313      313              
Flag Coverage Δ
integrationtests 65.29% <44.82%> (-3.17%) ⬇️
unittests 86.02% <98.00%> (+<0.01%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.02% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.55% <100.00%> (+0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.48% <ø> (ø)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.29% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.01% <ø> (-0.06%) ⬇️
storage 86.34% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.82% <96.55%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53197d...b46b894. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 careful there are multiple PRs with DB changes

@sonarqubecloud
Copy link

@pcrespov pcrespov disabled auto-merge February 13, 2025 10:00
@pcrespov pcrespov enabled auto-merge (squash) February 13, 2025 10:01
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@pcrespov pcrespov merged commit 510d846 into ITISFoundation:master Feb 13, 2025
93 of 95 checks passed
@pcrespov pcrespov deleted the is1822/product-ui-config branch February 13, 2025 10:12
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:database associated to postgres service and postgres-database package a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants