-
Notifications
You must be signed in to change notification settings - Fork 32
✨ product's ui config 🗃️ #7217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pcrespov
merged 14 commits into
ITISFoundation:master
from
pcrespov:is1822/product-ui-config
Feb 13, 2025
Merged
✨ product's ui config 🗃️ #7217
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
73ceb61
cleanup
pcrespov 5ca1ae5
drafts test
pcrespov ebf044b
api
pcrespov da4a735
services/webserver api version: 0.56.0 → 0.57.0
pcrespov e9683f6
adds col
pcrespov 4cf2f14
migration
pcrespov d8ec193
product repo
pcrespov 9fe66f7
tests
pcrespov ed27bfc
fix
matusdrobuliak66 83c5e0d
minor
pcrespov 41b02a6
cleanup
pcrespov 7af2bfd
fixes migration script
pcrespov 7edb4ad
Merge branch 'master' into is1822/product-ui-config
pcrespov b46b894
Merge branch 'master' into is1822/product-ui-config
odeimaiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| from datetime import datetime | ||
| from typing import Annotated, TypeAlias | ||
| from typing import Annotated, Any, TypeAlias | ||
|
|
||
| from common_library.basic_types import DEFAULT_FACTORY | ||
| from pydantic import ( | ||
| ConfigDict, | ||
| Field, | ||
|
|
@@ -10,6 +11,7 @@ | |
| PlainSerializer, | ||
| PositiveInt, | ||
| ) | ||
| from pydantic.config import JsonDict | ||
|
|
||
| from ..basic_types import IDStr, NonNegativeDecimal | ||
| from ..emails import LowerCaseEmailStr | ||
|
|
@@ -27,64 +29,83 @@ class GetCreditPrice(OutputSchema): | |
| description="Price of a credit in USD. " | ||
| "If None, then this product's price is UNDEFINED", | ||
| ) | ||
| min_payment_amount_usd: NonNegativeInt | None = Field( | ||
| ..., | ||
| description="Minimum amount (included) in USD that can be paid for this product" | ||
| "Can be None if this product's price is UNDEFINED", | ||
| ) | ||
| min_payment_amount_usd: Annotated[ | ||
| NonNegativeInt | None, | ||
| Field( | ||
| description="Minimum amount (included) in USD that can be paid for this product" | ||
| "Can be None if this product's price is UNDEFINED", | ||
| ), | ||
| ] | ||
|
|
||
| @staticmethod | ||
| def _update_json_schema_extra(schema: JsonDict) -> None: | ||
| schema.update( | ||
| { | ||
| "examples": [ | ||
| { | ||
| "productName": "osparc", | ||
| "usdPerCredit": None, | ||
| "minPaymentAmountUsd": None, | ||
| }, | ||
| { | ||
| "productName": "osparc", | ||
| "usdPerCredit": "10", | ||
| "minPaymentAmountUsd": "10", | ||
| }, | ||
| ] | ||
| } | ||
| ) | ||
|
|
||
| model_config = ConfigDict( | ||
| json_schema_extra={ | ||
| "examples": [ | ||
| { | ||
| "productName": "osparc", | ||
| "usdPerCredit": None, | ||
| "minPaymentAmountUsd": None, | ||
| }, | ||
| { | ||
| "productName": "osparc", | ||
| "usdPerCredit": "10", | ||
| "minPaymentAmountUsd": "10", | ||
| }, | ||
| ] | ||
| } | ||
| json_schema_extra=_update_json_schema_extra, | ||
| ) | ||
|
|
||
|
|
||
| class GetProductTemplate(OutputSchema): | ||
| id_: IDStr = Field(..., alias="id") | ||
| id_: Annotated[IDStr, Field(alias="id")] | ||
| content: str | ||
|
|
||
|
|
||
| class UpdateProductTemplate(InputSchema): | ||
| content: str | ||
|
|
||
|
|
||
| class GetProduct(OutputSchema): | ||
| class ProductGet(OutputSchema): | ||
| name: ProductName | ||
| display_name: str | ||
| short_name: str | None = Field( | ||
| default=None, description="Short display name for SMS" | ||
| ) | ||
|
|
||
| vendor: dict | None = Field(default=None, description="vendor attributes") | ||
| issues: list[dict] | None = Field( | ||
| default=None, description="Reference to issues tracker" | ||
| ) | ||
| manuals: list[dict] | None = Field(default=None, description="List of manuals") | ||
| support: list[dict] | None = Field( | ||
| default=None, description="List of support resources" | ||
| ) | ||
| short_name: Annotated[ | ||
| str | None, Field(description="Short display name for SMS") | ||
| ] = None | ||
|
|
||
| vendor: Annotated[dict | None, Field(description="vendor attributes")] = None | ||
| issues: Annotated[ | ||
| list[dict] | None, Field(description="Reference to issues tracker") | ||
| ] = None | ||
| manuals: Annotated[list[dict] | None, Field(description="List of manuals")] = None | ||
| support: Annotated[ | ||
| list[dict] | None, Field(description="List of support resources") | ||
| ] = None | ||
|
|
||
| login_settings: dict | ||
| max_open_studies_per_user: PositiveInt | None | ||
| is_payment_enabled: bool | ||
| credits_per_usd: NonNegativeDecimal | None | ||
|
|
||
| templates: list[GetProductTemplate] = Field( | ||
| default_factory=list, | ||
| description="List of templates available to this product for communications (e.g. emails, sms, etc)", | ||
| ) | ||
| templates: Annotated[ | ||
| list[GetProductTemplate], | ||
| Field( | ||
| description="List of templates available to this product for communications (e.g. emails, sms, etc)", | ||
| default_factory=list, | ||
| ), | ||
| ] = DEFAULT_FACTORY | ||
|
|
||
|
|
||
| class ProductUIGet(OutputSchema): | ||
| product_name: ProductName | ||
| ui: Annotated[ | ||
| dict[str, Any], | ||
| Field(description="Front-end owned ui product configuration"), | ||
| ] | ||
|
|
||
|
|
||
| ExtraCreditsUsdRangeInt: TypeAlias = Annotated[int, Field(ge=0, lt=500)] | ||
|
|
@@ -105,26 +126,32 @@ class InvitationGenerated(OutputSchema): | |
| created: datetime | ||
| invitation_link: HttpUrl | ||
|
|
||
| @staticmethod | ||
| def _update_json_schema_extra(schema: JsonDict) -> None: | ||
| schema.update( | ||
| { | ||
| "examples": [ | ||
| { | ||
| "productName": "osparc", | ||
| "issuer": "john.doe", | ||
| "guest": "[email protected]", | ||
| "trialAccountDays": 7, | ||
| "extraCreditsInUsd": 30, | ||
| "created": "2023-09-27T15:30:00", | ||
| "invitationLink": "https://example.com/invitation#1234", | ||
| }, | ||
| # w/o optional | ||
| { | ||
| "productName": "osparc", | ||
| "issuer": "[email protected]", | ||
| "guest": "[email protected]", | ||
| "created": "2023-09-27T15:30:00", | ||
| "invitationLink": "https://example.com/invitation#1234", | ||
| }, | ||
| ] | ||
| } | ||
| ) | ||
|
|
||
| model_config = ConfigDict( | ||
| json_schema_extra={ | ||
| "examples": [ | ||
| { | ||
| "productName": "osparc", | ||
| "issuer": "john.doe", | ||
| "guest": "[email protected]", | ||
| "trialAccountDays": 7, | ||
| "extraCreditsInUsd": 30, | ||
| "created": "2023-09-27T15:30:00", | ||
| "invitationLink": "https://example.com/invitation#1234", | ||
| }, | ||
| # w/o optional | ||
| { | ||
| "productName": "osparc", | ||
| "issuer": "[email protected]", | ||
| "guest": "[email protected]", | ||
| "created": "2023-09-27T15:30:00", | ||
| "invitationLink": "https://example.com/invitation#1234", | ||
| }, | ||
| ] | ||
| } | ||
| json_schema_extra=_update_json_schema_extra, | ||
| ) | ||
36 changes: 36 additions & 0 deletions
36
...e/src/simcore_postgres_database/migration/versions/78f24aaf3f78_new_products_ui_column.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| """new products ui column | ||
|
|
||
| Revision ID: 78f24aaf3f78 | ||
| Revises: 68777fdf9539 | ||
| Create Date: 2025-02-12 16:06:09.815111+00:00 | ||
|
|
||
| """ | ||
| import sqlalchemy as sa | ||
| from alembic import op | ||
| from sqlalchemy.dialects import postgresql | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = "78f24aaf3f78" | ||
| down_revision = "68777fdf9539" | ||
| branch_labels = None | ||
| depends_on = None | ||
|
|
||
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.add_column( | ||
| "products", | ||
| sa.Column( | ||
| "ui", | ||
| postgresql.JSONB(astext_type=sa.Text()), | ||
| server_default=sa.text("'{}'::jsonb"), | ||
| nullable=False, | ||
| ), | ||
| ) | ||
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.drop_column("products", "ui") | ||
| # ### end Alembic commands ### |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0.56.0 | ||
| 0.57.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.