♻️ Refactor and polish api keys domain of webserver

[bisgaard-itis]

What do these changes do?

• Minor refactoring of api keys section of the web server.
• Remove dead code
• Ensure code coverage is above 90%. Here's the code coverage report for the api-keys domain of the webserver (based on unit tests)

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (27f40cc) to head (e40ba3b).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7293      +/-   ##
==========================================
- Coverage   87.14%   83.76%   -3.38%     
==========================================
  Files        1690      663    -1027     
  Lines       65633    31631   -34002     
  Branches     1121      168     -953     
==========================================
- Hits        57193    26496   -30697     
+ Misses       8120     5077    -3043     
+ Partials      320       58     -262     

Flag	Coverage Δ
integrationtests	65.40% <60.00%> (+0.02%)	⬆️
unittests	86.62% <100.00%> (+0.33%)	⬆️

Components	Coverage Δ
api	76.84% <ø> (ø)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.30% <ø> (-8.16%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	78.51% <ø> (-12.79%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	89.74% <ø> (ø)
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	85.29% <100.00%> (+0.04%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f40cc...e40ba3b. Read the comment docs.

[pcrespov]

thx but ... come on, get it to 100% .. just a few lines missing in the most important modules: repository and rest controller! ;-)

[matusdrobuliak66]

Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud