Skip to content

🎨Storage: Increased maximum number of returned paths to 1000 #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanderegg merged 13 commits into from
Mar 4, 2025
Merged

🎨Storage: Increased maximum number of returned paths to 1000 #7305

sanderegg merged 13 commits into from
Mar 4, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 4, 2025 •
edited
Loading

What do these changes do?

required by frontend, to allow to do stepped upgrades. the max limit of the paths listing is increased to 1000

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 4, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 4, 2025
@sanderegg sanderegg self-assigned this Mar 4, 2025
odeimaiz
odeimaiz approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanderegg sanderegg marked this pull request as ready for review March 4, 2025 11:28
GitHK
GitHK approved these changes Mar 4, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (996febd) to head (2a862e6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7305      +/-   ##
==========================================
- Coverage   87.10%   86.99%   -0.12%     
==========================================
  Files        1670     1524     -146     
  Lines       65130    61868    -3262     
  Branches     1121      891     -230     
==========================================
- Hits        56734    53823    -2911     
+ Misses       8076     7786     -290     
+ Partials      320      259      -61
Flag Coverage Δ
integrationtests 65.39% <ø> (+0.01%) ⬆️
unittests 86.09% <55.55%> (-0.16%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.58% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.61% <0.00%> (-0.11%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <100.00%> (-0.01%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 91.73% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.06% <ø> (∅)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.28% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.11% <ø> (ø)
storage 84.57% <100.00%> (+0.09%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.29% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996febd...2a862e6. Read the comment docs.

@sanderegg sanderegg force-pushed the storage/listing-paths-increase-max-limit branch from dea6875 to b712b65 Compare March 4, 2025 12:20
pcrespov
pcrespov approved these changes Mar 4, 2025
View reviewed changes
@sanderegg sanderegg force-pushed the storage/listing-paths-increase-max-limit branch 2 times, most recently from 8e38cd1 to a6c0c98 Compare March 4, 2025 13:58
@sanderegg sanderegg force-pushed the storage/listing-paths-increase-max-limit branch from b857fec to 2a862e6 Compare March 4, 2025 17:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit a059026 into ITISFoundation:master Mar 4, 2025
90 of 95 checks passed
@sanderegg sanderegg deleted the storage/listing-paths-increase-max-limit branch March 4, 2025 20:10
This was referenced Mar 6, 2025
Merged
Closed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@sanderegg @mrnicegyu11
🎨Storage: Increased maximum number of returned paths to 1000 (ITISFou…
dde5f6e 
…ndation#7305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@sanderegg sanderegg

Labels

a:storage issue related to storage service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

6 participants

@sanderegg @giancarloromeo @GitHK @pcrespov @odeimaiz @matusdrobuliak66