Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 6, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Mar 6, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 6, 2025
@sanderegg sanderegg self-assigned this Mar 6, 2025
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (b1df292) to head (0136f23).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (b1df292) and HEAD (0136f23). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (b1df292) HEAD (0136f23)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7313       +/-   ##
===========================================
- Coverage   85.68%   68.67%   -17.02%     
===========================================
  Files        1692      704      -988     
  Lines       65759    33559    -32200     
  Branches     1121      168      -953     
===========================================
- Hits        56347    23047    -33300     
- Misses       9092    10454     +1362     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.40% <ø> (+0.01%) ⬆️
unittests 84.43% <100.00%> (-0.20%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.53% <ø> (-12.78%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.43% <ø> (-0.86%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 84.43% <100.00%> (+0.19%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.41% <ø> (-20.90%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1df292...0136f23. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh yes the forever issue of urls and quotes

@sanderegg sanderegg force-pushed the storage/bugfix/upload-with-parenthesis branch from 3540cd1 to 0136f23 Compare March 6, 2025 15:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(tested) 👌

@sanderegg sanderegg merged commit 6835b03 into ITISFoundation:master Mar 6, 2025
91 of 95 checks passed
@sanderegg sanderegg deleted the storage/bugfix/upload-with-parenthesis branch March 6, 2025 15:41
@sanderegg sanderegg mentioned this pull request Mar 6, 2025
63 tasks
matusdrobuliak66 pushed a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Mar 7, 2025
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants