Skip to content

🐛Storage: quote returned links such that they are usable with files containing parentheses #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanderegg merged 1 commit into from
Mar 6, 2025
Merged

🐛Storage: quote returned links such that they are usable with files containing parentheses #7313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions services/storage/src/simcore_service_storage/api/rest/_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import asyncio
import logging
from typing import Annotated, cast
from urllib.parse import quote

from fastapi import APIRouter, Depends, Header, HTTPException, Request
from models_library.api_schemas_storage.storage_schemas import (
Expand Down Expand Up @@ -202,23 +203,31 @@ async def upload_file(
abort_url = (
URL(f"{request.url}")
.with_path(
request.app.url_path_for(
"abort_upload_file",
location_id=f"{location_id}",
file_id=file_id,
)
quote(
request.app.url_path_for(
"abort_upload_file",
location_id=f"{location_id}",
file_id=file_id,
),
safe=":/",
),
encoded=True,
)
.with_query(user_id=query_params.user_id)
)

complete_url = (
URL(f"{request.url}")
.with_path(
request.app.url_path_for(
"complete_upload_file",
location_id=f"{location_id}",
file_id=file_id,
)
quote(
request.app.url_path_for(
"complete_upload_file",
location_id=f"{location_id}",
file_id=file_id,
),
safe=":/",
),
encoded=True,
)
.with_query(user_id=query_params.user_id)
)
Expand Down Expand Up @@ -273,12 +282,16 @@ async def complete_upload_file(
route = (
URL(f"{request.url}")
.with_path(
request.app.url_path_for(
"is_completed_upload_file",
location_id=f"{location_id}",
file_id=file_id,
future_id=task.get_name(),
)
quote(
request.app.url_path_for(
"is_completed_upload_file",
location_id=f"{location_id}",
file_id=file_id,
future_id=task.get_name(),
),
safe=":/",
),
encoded=True,
)
.with_query(user_id=query_params.user_id)
)
Expand Down
Loading