Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 27, 2025

What do these changes do?

This PR finishes fixing the path:size frontend's workflow. I was extracting the result the old way and now it's fixed and complete. I also added a size check to the sleepers tests that runs in the CI.

PathSize

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review March 27, 2025 09:18
@odeimaiz odeimaiz self-assigned this Mar 27, 2025
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Mar 27, 2025
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (c9296d7) to head (068c84a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7441      +/-   ##
==========================================
- Coverage   87.42%   86.08%   -1.34%     
==========================================
  Files        1723     1717       -6     
  Lines       66749    66469     -280     
  Branches     1133     1132       -1     
==========================================
- Hits        58356    57221    -1135     
- Misses       8072     8942     +870     
+ Partials      321      306      -15     
Flag Coverage Δ *Carryforward flag
integrationtests 58.17% <ø> (-6.97%) ⬇️
unittests 86.62% <ø> (+0.02%) ⬆️ Carriedforward from 0d58ad8

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.90% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 92.04% <ø> (-0.01%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.99% <ø> (+0.35%) ⬆️
pkg_settings_library 90.78% <ø> (ø)
pkg_simcore_sdk 65.72% <ø> (-19.74%) ⬇️
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (-0.09%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 92.10% <ø> (+0.27%) ⬆️
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.70% <ø> (ø)
director_v2 84.58% <ø> (-6.72%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.17% <ø> (-0.94%) ⬇️
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (+0.21%) ⬆️
storage 86.16% <ø> (-0.45%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.53% <ø> (-0.39%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9296d7...068c84a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@odeimaiz odeimaiz enabled auto-merge (squash) March 28, 2025 08:50
@sonarqubecloud
Copy link

@odeimaiz odeimaiz merged commit 1c829d7 into ITISFoundation:master Mar 28, 2025
57 checks passed
@odeimaiz odeimaiz deleted the fix/path-size branch March 28, 2025 10:23
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 28, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants