Skip to content

🐛 [Frontend] Fix: Extract path :size #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 28, 2025
Merged

🐛 [Frontend] Fix: Extract path :size #7441

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
82c3ebe
add logo and strong_color to Vendor's model
odeimaiz Mar 26, 2025
da19b57
Merge remote-tracking branch 'upstream/master'
odeimaiz Mar 27, 2025
684eee9
extract result
odeimaiz Mar 27, 2025
0d719a2
minor
odeimaiz Mar 27, 2025
bf259af
add test
odeimaiz Mar 27, 2025
a8f6729
Revert "add logo and strong_color to Vendor's model"
odeimaiz Mar 27, 2025
ad5816d
print
odeimaiz Mar 27, 2025
c510d6f
aesthetics
odeimaiz Mar 27, 2025
068c84a
Merge branch 'master' into fix/path-size
odeimaiz Mar 28, 2025
b244bfa
undo test
odeimaiz Mar 28, 2025
817f06f
Merge branch 'master' into fix/path-size
odeimaiz Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/static-webserver/client/source/class/osparc/desktop/account/MyAccountWindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ qx.Class.define("osparc.desktop.account.MyAccountWindow", {
construct: function() {
this.base(arguments, "credits", this.tr("My Account"));

const width = 990;
const width = 850;
const height = 700;
const maxHeight = 700;
this.set({
Expand Down
2 changes: 0 additions & 2 deletions services/static-webserver/client/source/class/osparc/desktop/preferences/pages/TagsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ qx.Class.define("osparc.desktop.preferences.pages.TagsPage", {
const intro = osparc.ui.window.TabbedView.createHelpLabel(msg);
this._add(intro);

this._add(new qx.ui.core.Spacer(null, 10));

this.__renderLayout();
},

Expand Down
5 changes: 3 additions & 2 deletions services/static-webserver/client/source/class/osparc/file/TreeFolderView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,11 @@ qx.Class.define("osparc.file.TreeFolderView", {
pollTasks.createPollingTask(fetchPromise)
.then(task => {
task.addListener("resultReceived", e => {
const size = e.getData();
const data = e.getData();
const size = (data && "result" in data) ? osparc.utils.Utils.bytesToSize(data["result"]) : "-";
totalSize.set({
icon: null,
label: this.tr("Total size: ") + osparc.utils.Utils.bytesToSize(size),
label: this.tr("Total size: ") + size,
});
});
task.addListener("pollingError", e => totalSize.hide());
Expand Down
6 changes: 6 additions & 0 deletions tests/e2e-playwright/tests/sleepers/test_sleepers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
SocketIOEvent,
retrieve_project_state_from_decoded_message,
wait_for_pipeline_state,
wait_for_label_text,
)
from tenacity import retry, retry_if_exception_type, stop_after_delay, wait_fixed

Expand Down Expand Up @@ -226,4 +227,9 @@ def test_sleepers(
)
ctx.logger.info(msg)
assert output_file_names_found == sleeper_expected_output_files

# now check if the "Total size:"" widget shows something
label = wait_for_label_text(page, "totalSizeLabel", "Total size:", 20000)
ctx.logger.info(f"1st node size: {label.inner_text()}")

page.get_by_test_id("nodeDataManagerCloseBtn").click()
Loading