-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Feature: on share project email #7455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Feature: on share project email #7455
Conversation
…simcore into enh/prettify-base-email
packages/notifications-library/src/notifications_library/_email_render.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/faker_factories.py
Outdated
Show resolved
Hide resolved
...otifications-library/src/notifications_library/templates/on_share_project.email.content.html
Show resolved
Hide resolved
...otifications-library/src/notifications_library/templates/on_share_project.email.content.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (17)
- packages/notifications-library/src/notifications_library/templates/on_change_email.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_change_email.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_new_code.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_new_code.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_new_invitation.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_new_invitation.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_payed.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_payed.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_registered.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_registered.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_reset_password.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_reset_password.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_share_project.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_share_project.email.content.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_share_project.email.subject.txt: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_unregister.email.content.html: Language not supported
- packages/notifications-library/src/notifications_library/templates/on_unregister.email.content.txt: Language not supported
Comments suppressed due to low confidence (1)
packages/notifications-library/tests/conftest.py:98
- [nitpick] Consider parameterizing the 'sharer_data' fixture to explicitly test both cases (with and without a sharer message) to ensure comprehensive test coverage.
message=faker.random_element(elements=(faker.sentence(), "")),
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f272e95 |
|



What do these changes do?
This PR brings the
on_share_projectemail template. In addition to the usual data used for composing the email, it introduces theSharerDatamodel that includes who is sharing the project and an optional message from the sharer that can get injected in the email.Related issue/s
How to test
Dev-ops checklist