Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 31, 2025

What do these changes do?

This PR brings the on_share_project email template. In addition to the usual data used for composing the email, it introduces the SharerData model that includes who is sharing the project and an optional message from the sharer that can get injected in the email.

image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz requested a review from Copilot April 7, 2025 09:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 26 changed files in this pull request and generated no comments.

Files not reviewed (17)
  • packages/notifications-library/src/notifications_library/templates/on_change_email.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_change_email.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_new_code.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_new_code.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_new_invitation.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_new_invitation.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_payed.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_payed.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_registered.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_registered.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_reset_password.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_reset_password.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_share_project.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_share_project.email.content.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_share_project.email.subject.txt: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_unregister.email.content.html: Language not supported
  • packages/notifications-library/src/notifications_library/templates/on_unregister.email.content.txt: Language not supported
Comments suppressed due to low confidence (1)

packages/notifications-library/tests/conftest.py:98

  • [nitpick] Consider parameterizing the 'sharer_data' fixture to explicitly test both cases (with and without a sharer message) to ensure comprehensive test coverage.
message=faker.random_element(elements=(faker.sentence(), "")),

@odeimaiz odeimaiz requested a review from pcrespov April 7, 2025 09:34
@odeimaiz odeimaiz modified the milestones: The Awakening, Pauwel Kwak Apr 7, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 7, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 7, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f272e95

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@mergify mergify bot merged commit f272e95 into ITISFoundation:master Apr 7, 2025
95 checks passed
@odeimaiz odeimaiz deleted the feature/on-share-project-email branch April 7, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants