Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Apr 3, 2025

What do these changes do?

This PR introduces the Celery routing queues, used to send tasks to specific instances of sto-workers.

BONUS:
Tasks metadata are now stored separately (different keys set in Redis) and new ephemeral tasks are removed once the result is taken.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added this to the The Awakening milestone Apr 3, 2025
@giancarloromeo giancarloromeo self-assigned this Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (2aa5080) to head (22c83da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7471      +/-   ##
==========================================
+ Coverage   87.46%   87.47%   +0.01%     
==========================================
  Files        1741     1734       -7     
  Lines       67323    67169     -154     
  Branches     1142     1142              
==========================================
- Hits        58882    58758     -124     
+ Misses       8121     8091      -30     
  Partials      320      320              
Flag Coverage Δ
integrationtests 65.12% <ø> (+<0.01%) ⬆️
unittests 86.66% <95.71%> (+0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.94% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.82% <ø> (ø)
pkg_settings_library 90.79% <100.00%> (+0.01%) ⬆️
pkg_simcore_sdk 85.40% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.02% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.92% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.35% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.29% <ø> (+0.16%) ⬆️
storage 87.81% <95.65%> (-0.03%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.88% <ø> (-0.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa5080...22c83da. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the add-celery-routing-queues branch from 3b69bc3 to 7fa116a Compare April 4, 2025 13:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

@giancarloromeo giancarloromeo merged commit 08ce0fe into ITISFoundation:master Apr 9, 2025
94 checks passed
@giancarloromeo giancarloromeo deleted the add-celery-routing-queues branch April 9, 2025 21:19
@giancarloromeo giancarloromeo changed the title ✨ Add Celery routing queues ✨ Add Celery routing queues ⚠️ Apr 15, 2025
@YuryHrytsuk YuryHrytsuk changed the title ✨ Add Celery routing queues ⚠️ ✨ Add Celery routing queues ⚠️ DEVOPS Apr 15, 2025
YuryHrytsuk added a commit to ITISFoundation/osparc-ops-environments that referenced this pull request Apr 15, 2025
* Add sto-worker-cpu-bound service

Related PR(s):
* ITISFoundation/osparc-simcore#7471
* https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1362

* Bump memory limit

Based on experiment data (we saw 600MB memory usage uploading 2 files)
@giancarloromeo giancarloromeo changed the title ✨ Add Celery routing queues ⚠️ DEVOPS ✨ Add Celery routing queues ⚠️ Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage celery client raises badly formed hexadecimal UUID string and is not handled on the webserver

5 participants