🎨E2E: playwright improvements #7500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7500 +/- ##
==========================================
+ Coverage 87.44% 87.46% +0.01%
==========================================
Files 1741 1734 -7
Lines 67375 67185 -190
Branches 1142 1142
==========================================
- Hits 58917 58763 -154
+ Misses 8138 8104 -34
+ Partials 320 318 -2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fix timeouts
sanderegg
force-pushed
the
maintenance/playwright-improvements
branch
from
44f264a to
0dd64f9
Compare
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Apr 10, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Thanks a lot 🥇
pcrespov
approved these changes
Apr 10, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
paired review. great job. Left some comments
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
|
This was referenced Apr 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request includes several changes aimed at improving the robustness and functionality of the WebSocket handling in the
pytest-simcorepackage, as well as adding new utility functions for service endpoint checking. The most important changes include renaming theRestartableWebSocketclass toRobustWebSocket, adding retry logic for WebSocket reconnections, and introducing new functions to check and wait for service endpoints.Improvements to WebSocket handling:
RestartableWebSocketclass toRobustWebSocketand added theauto_reconnectattribute to enable automatic reconnections._attempt_reconnectmethod using thetenacitylibrary to handle reconnections more robustly.test_robust_websocket.pytest to test the RobustWebSocketuv initand adding some missing libraries (currently only for that test), note that the pytest-simcore library is not CI tested.Service endpoint checking:
_get_service_urland_check_service_endpointfunctions to validate and check the readiness of service endpoints. [1] [2]wait_for_service_endpoint_respondingfunction to emulate frontend polling until the service endpoint responds with a 2xx/3xx status code.SocketIONodeProgressCompleteWaiteras this is incompatible with fast returning function called in separate threadsCode cleanup and refactoring:
assert_service_readymethod and related attributes from theSocketIONodeProgressCompleteWaiterclass, as the new service endpoint checking functions handle these checks.RobustWebSocketclass and the new service endpoint checking logic. [1] [2]Related issue/s
How to test
Dev-ops checklist