Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Apr 10, 2025

What do these changes do?

  • Fix bug in our celery test worker fixture.
  • I double checked and signals should not be sent in the celery test worker, only connected. That means we were sending the shutdown signal twice which seems to be the thing causing the hang

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Apr 10, 2025
@bisgaard-itis bisgaard-itis added the a:storage issue related to storage service label Apr 10, 2025
@bisgaard-itis bisgaard-itis added this to the Pauwel Kwak milestone Apr 10, 2025
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.96%. Comparing base (c4f3dca) to head (cad844e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c4f3dca) and HEAD (cad844e). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (c4f3dca) HEAD (cad844e)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7501       +/-   ##
===========================================
- Coverage   87.44%   68.96%   -18.48%     
===========================================
  Files        1741      739     -1002     
  Lines       67375    34610    -32765     
  Branches     1142      170      -972     
===========================================
- Hits        58913    23870    -35043     
- Misses       8142    10682     +2540     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.19% <ø> (+0.02%) ⬆️
unittests 87.73% <ø> (+1.10%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.24% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.58% <ø> (-12.72%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.73% <ø> (-0.04%) ⬇️
webclient ∅ <ø> (∅)
webserver 59.11% <ø> (-26.76%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f3dca...cad844e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis marked this pull request as ready for review April 10, 2025 08:21
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! that makes total sense now ;)

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 10, 2025 08:42
@sonarqubecloud
Copy link

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bisgaard-itis, this solves the tests issue but not the one we experience running the full stack 👌

@bisgaard-itis bisgaard-itis merged commit bb3b81c into ITISFoundation:master Apr 10, 2025
91 of 94 checks passed
@bisgaard-itis bisgaard-itis deleted the fix-celery-abort-test branch April 10, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cancelling async_job blocks tests

3 participants