Skip to content

🐛 Fix abort task test #7501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

🐛 Fix abort task test #7501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e2be0d
unskip test and dont send signals
bisgaard-itis Apr 10, 2025
fae22eb
Merge branch 'master' into fix-celery-abort-test
bisgaard-itis Apr 10, 2025
cad844e
Merge branch 'master' into fix-celery-abort-test
bisgaard-itis Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions services/storage/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,12 +1018,8 @@ async def with_storage_celery_worker_controller(
perform_ping_check=False,
queues="default,cpu_bound",
) as worker:
worker_init.send(sender=worker)

yield worker

worker_shutdown.send(sender=worker)


@pytest.fixture
def with_storage_celery_worker(
Expand Down
12 changes: 2 additions & 10 deletions services/storage/tests/unit/test_async_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ async def _wait_for_job(
{"a", "set"},
],
)
async def test_asybc_jobs_workflow(
async def test_async_jobs_workflow(
initialized_app: FastAPI,
register_rpc_routes: None,
storage_rabbitmq_rpc_client: RabbitMQRPCClient,
Expand Down Expand Up @@ -241,15 +241,7 @@ async def test_asybc_jobs_workflow(
"exposed_rpc_start",
[
rpc_sync_job.__name__,
pytest.param(
rpc_async_job.__name__,
marks=pytest.mark.skip(
reason=(
"hangs after teardown for unknown reason "
"SEE https://github.com/ITISFoundation/osparc-simcore/issues/7486"
)
),
),
rpc_async_job.__name__,
],
)
async def test_async_jobs_cancel(
Expand Down
Loading