-
Notifications
You must be signed in to change notification settings - Fork 32
✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases 🚨 #7769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases 🚨 #7769
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7769 +/- ##
===========================================
- Coverage 86.73% 66.49% -20.25%
===========================================
Files 1850 751 -1099
Lines 71863 35438 -36425
Branches 1215 176 -1039
===========================================
- Hits 62332 23565 -38767
- Misses 9190 11815 +2625
+ Partials 341 58 -283
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
5c8a98e to
5c452c4
Compare
|
@mergify queue |
🟠 Waiting for conditions to match
|
1e81c61 to
964ef59
Compare
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice. thanks!
services/catalog/src/simcore_service_catalog/core/background_tasks.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/service/access_rights.py
Outdated
Show resolved
Hide resolved
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
…ble across test files
…tions for user group and product exposure
… inheritance tests
…pdating metadata inheritance tests
483c30b to
6f8984e
Compare
|
@mergify queue |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at c3e1573 |
|



What do these changes do?
If a service does not define upon release an
icon(asked in the associated issue bu @odeimaiz ) orthumbnail(requested by @mguidon), it inherits the one from previous compatible releaseRelated issue/s
How to test
🚨 test in master before deploying to staging!
Dev-ops