Skip to content

✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases 🚨 #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 3, 2025
Merged

✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases 🚨 #7769

merged 17 commits into from
Jun 3, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 30, 2025 •
edited
Loading

What do these changes do?

If a service does not define upon release an icon (asked in the associated issue bu @odeimaiz ) or thumbnail (requested by @mguidon), it inherits the one from previous compatible release

Related issue/s

  • Closes ITISFoundation/private-issues#34

How to test

cd services/catalog
make install-dev
pytest -vv tests/unit/with_dbs/test_service_access_rights.py

🚨 test in master before deploying to staging!

Dev-ops

@pcrespov pcrespov added this to the Bazinga! milestone May 30, 2025
@pcrespov pcrespov self-assigned this May 30, 2025
@pcrespov pcrespov added the a:catalog catalog service label May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.49%. Comparing base (79d6080) to head (32ffc95).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (79d6080) and HEAD (32ffc95). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (79d6080) HEAD (32ffc95)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7769       +/-   ##
===========================================
- Coverage   86.73%   66.49%   -20.25%     
===========================================
  Files        1850      751     -1099     
  Lines       71863    35438    -36425     
  Branches     1215      176     -1039     
===========================================
- Hits        62332    23565    -38767     
- Misses       9190    11815     +2625     
+ Partials      341       58      -283
Flag Coverage Δ
integrationtests 64.17% <ø> (-0.02%) ⬇️
unittests 92.29% <100.00%> (+5.80%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.90% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 92.29% <100.00%> (+0.04%) ⬆️
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.66% <ø> (-13.45%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 56.39% <ø> (-27.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d6080...32ffc95. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov force-pushed the is34/catalog-inherit-icon branch from 5c8a98e to 5c452c4 Compare May 30, 2025 14:09
@pcrespov pcrespov changed the title WIP: ✨ Is34/catalog inherit icon ✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases May 30, 2025
@pcrespov pcrespov marked this pull request as ready for review May 30, 2025 15:32
@pcrespov pcrespov requested a review from sanderegg as a code owner May 30, 2025 15:32
@pcrespov pcrespov requested review from GitHK, mguidon and odeimaiz May 30, 2025 15:33
@pcrespov pcrespov enabled auto-merge (squash) May 30, 2025 15:33
@pcrespov
Copy link
Member Author

pcrespov commented May 30, 2025

@mergify queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label May 30, 2025
@mergify
Copy link
Contributor

mergify bot commented May 30, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@pcrespov pcrespov force-pushed the is34/catalog-inherit-icon branch from 1e81c61 to 964ef59 Compare May 30, 2025 15:46
sanderegg
sanderegg approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. thanks!

GitHK
GitHK approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is34/catalog-inherit-icon branch from 483c30b to 6f8984e Compare June 3, 2025 16:32
@pcrespov pcrespov requested a review from bisgaard-itis June 3, 2025 16:32
@pcrespov
Copy link
Member Author

pcrespov commented Jun 3, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2025 •
edited
Loading

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at c3e1573

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov merged commit c3e1573 into ITISFoundation:master Jun 3, 2025
92 of 96 checks passed
@pcrespov pcrespov changed the title ✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases ✨ catalog: new service inherit icon and thumbnail from latest patched compatible releases 🚨 Jun 3, 2025
@pcrespov pcrespov deleted the is34/catalog-inherit-icon branch June 3, 2025 17:59
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@mguidon mguidon Awaiting requested review from mguidon

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:catalog catalog service

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

3 participants

@pcrespov @GitHK @sanderegg