🐛 [Frontend] Fix: Edit slides #7832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
Konohana0608,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a frontend bug where editing slides was incorrectly enabled/disabled based on the study mode.
- In Services.js, additional truthiness checks were added to prevent overwriting complete cached entries.
- In StudyEditor.js, the conditional for editing slides was modified to correctly restrict editing in "app" and "guided" modes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Services.js | Added explicit truthiness checks to safeguard against overwriting complete cache entries. |
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Adjusted the condition to restrict editing slides when the mode is "app" or "guided". |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/store/Services.js:392
- Consider adding a comment to clarify why an explicit truthiness check for this.__servicesCached[key][version] is necessary, even though __isInCache() verifies key and version exist.
this.__servicesCached[key][version] &&
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:539
- The inline comment should be updated to accurately reflect that the condition checks for both 'app' and 'guided' modes, not just 'app'.
if (["app", "guided"].includes(this.getStudy().getUi().getMode())) {
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b43e721 |
GitHK
approved these changes
Jun 5, 2025
sanderegg
approved these changes
Jun 5, 2025
pcrespov
approved these changes
Jun 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
reported by @Konohana0608
Fixed:
Related issue/s
How to test
Dev-ops