Skip to content

🐛 [Frontend] Fix: Edit slides #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

🐛 [Frontend] Fix: Edit slides #7832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca96b91
fix edit slides
odeimaiz Jun 5, 2025
bf4c765
minor
odeimaiz Jun 5, 2025
663e41f
Merge branch 'master' into fix/edit-slides
mergify[bot] Jun 5, 2025
1ec9293
Merge branch 'master' into fix/edit-slides
mergify[bot] Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,8 @@ qx.Class.define("osparc.desktop.StudyEditor", {
},

__editSlides: function() {
if (this.getStudy().getUi().getMode() !== "workbench") {
// if the user is not in "workbench" mode, return
if (["app", "guided"].includes(this.getStudy().getUi().getMode())) {
// if the user is in "app" mode, return
return;
}

Expand Down
2 changes: 2 additions & 0 deletions services/static-webserver/client/source/class/osparc/store/Services.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,12 +389,14 @@ qx.Class.define("osparc.store.Services", {
// if the one in the cache is the complete one, do not overwrite it
if (
this.__isInCache(key, version) &&
this.__servicesCached[key][version] &&
"history" in this.__servicesCached[key][version] // the most complete service metadata is already in cache
) {
return;
}
if (
this.__isInCache(key, version) &&
this.__servicesCached[key][version] &&
"inputs" in this.__servicesCached[key][version] && // this is the second most complete service metadata (/latest)
value && !("inputs" in value) // the one to be added is not more complete
) {
Expand Down
Loading