-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 revert to previous long_running_tasks interface #7903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 revert to previous long_running_tasks interface #7903
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7903 +/- ##
==========================================
- Coverage 87.94% 87.84% -0.10%
==========================================
Files 1845 1428 -417
Lines 71141 59344 -11797
Branches 1220 623 -597
==========================================
- Hits 62562 52131 -10431
+ Misses 8227 7004 -1223
+ Partials 352 209 -143
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
@Mergifyio queue |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
packages/service-library/src/servicelib/aiohttp/long_running_tasks/_routes.py
Show resolved
Hide resolved
🟠 Waiting for conditions to match
|



What do these changes do?
The interface of
long_running_tasksgot accidentally changed by altering a test, causing director-v2 to no longer tread errors as it should.Also task removal was also accidentally changed and not sopped during reviews, this was also reverted, to avoid code raising unexpected errors.
Related issue/s
How to test
Dev-ops