Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

After #7904, Sonarcloud was complaining about duplicated code. This PR fixes this.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jun 17, 2025
@sanderegg sanderegg self-assigned this Jun 17, 2025
@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs 🤖-automerge marks PR as ready to be merged for Mergify labels Jun 17, 2025
@sanderegg sanderegg changed the title ♻️ Remove code duplication after [#7904](https://github.com/ITISFoundation/osparc-simcore/pull/7904) ♻️ Remove code duplication after [#7904] Jun 17, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

queue

🛑 This queue command has been cancelled by a dequeue command

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (a50321d) to head (9e3810f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7915      +/-   ##
==========================================
- Coverage   86.88%   84.97%   -1.92%     
==========================================
  Files        1670      691     -979     
  Lines       65190    32643   -32547     
  Branches     1173      176     -997     
==========================================
- Hits        56638    27737   -28901     
+ Misses       8224     4848    -3376     
+ Partials      328       58     -270     
Flag Coverage Δ
integrationtests 64.22% <60.00%> (+1.85%) ⬆️
unittests 86.78% <100.00%> (+0.83%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.10% <ø> (+11.71%) ⬆️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.67% <ø> (-13.48%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.61% <100.00%> (+0.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50321d...9e3810f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg
Copy link
Member Author

@mergify unqueue

@matusdrobuliak66
Copy link
Collaborator

@mergify stop

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

unqueue

✅ The pull request is not waiting to be queued anymore.

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

stop

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@matusdrobuliak66
Copy link
Collaborator

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sanderegg sanderegg force-pushed the i1913/use-one-connection-sonar branch from 0874e7b to 9e3810f Compare June 17, 2025 15:37
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0d75a45

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 0d75a45 into ITISFoundation:master Jun 17, 2025
95 of 96 checks passed
@sanderegg sanderegg deleted the i1913/use-one-connection-sonar branch June 17, 2025 16:27
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 20, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants