Skip to content

♻️ Remove code duplication after [#7904] #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

♻️ Remove code duplication after [#7904] #7915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 31 additions & 37 deletions services/web/server/src/simcore_service_webserver/functions/_functions_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,14 +627,14 @@ async def delete_function(
)


async def update_function_title(
async def _update_function_attribute(
app: web.Application,
connection: AsyncConnection | None = None,
connection: AsyncConnection | None,
*,
user_id: UserID,
product_name: ProductName,
function_id: FunctionID,
title: str,
**update_kwargs,
) -> RegisteredFunctionDB:
async with transaction_context(get_asyncpg_engine(app), connection) as transaction:
await check_user_api_access_rights(
Expand All @@ -661,7 +661,7 @@ async def update_function_title(
result = await transaction.execute(
functions_table.update()
.where(functions_table.c.uuid == function_id)
.values(title=title)
.values(**update_kwargs)
.returning(*_FUNCTIONS_TABLE_COLS)
)
row = result.one_or_none()
Expand All @@ -672,48 +672,42 @@ async def update_function_title(
return RegisteredFunctionDB.model_validate(row)


async def update_function_description(
async def update_function_title(
app: web.Application,
connection: AsyncConnection | None = None,
*,
user_id: UserID,
product_name: ProductName,
function_id: FunctionID,
description: str,
title: str,
) -> RegisteredFunctionDB:
async with transaction_context(get_asyncpg_engine(app), connection) as transaction:
await check_user_api_access_rights(
app,
connection=transaction,
user_id=user_id,
product_name=product_name,
api_access_rights=[
FunctionsApiAccessRights.READ_FUNCTIONS,
FunctionsApiAccessRights.WRITE_FUNCTIONS,
],
)
await check_user_permissions(
app,
transaction,
user_id=user_id,
product_name=product_name,
object_id=function_id,
object_type="function",
permissions=["write"],
)

result = await transaction.execute(
functions_table.update()
.where(functions_table.c.uuid == function_id)
.values(description=description)
.returning(*_FUNCTIONS_TABLE_COLS)
)
row = result.one_or_none()
return await _update_function_attribute(
app,
connection=connection,
user_id=user_id,
product_name=product_name,
function_id=function_id,
title=title,
)

if row is None:
raise FunctionIDNotFoundError(function_id=function_id)

return RegisteredFunctionDB.model_validate(row)
async def update_function_description(
app: web.Application,
connection: AsyncConnection | None = None,
*,
user_id: UserID,
product_name: ProductName,
function_id: FunctionID,
description: str,
) -> RegisteredFunctionDB:
return await _update_function_attribute(
app,
connection=connection,
user_id=user_id,
product_name=product_name,
function_id=function_id,
description=description,
)


async def get_function_job(
Expand Down
Loading