-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Send Socket.IO events whenever conversation messages are created, updated, or deleted #7941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Send Socket.IO events whenever conversation messages are created, updated, or deleted #7941
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7941 +/- ##
==========================================
- Coverage 87.85% 84.97% -2.89%
==========================================
Files 1848 692 -1156
Lines 71283 32717 -38566
Branches 1250 176 -1074
==========================================
- Hits 62629 27801 -34828
+ Misses 8292 4858 -3434
+ Partials 362 58 -304
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks.
Could you also add (in a follow up PR if you want) from what kind of action the event comes from? For now, I can assume that I'm dealing with a new message (added), but in the future we will also need to handle edited and deleted messages.
...ices/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/02/test_projects_conversations_handlers.py
Outdated
Show resolved
Hide resolved
...ices/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py
Outdated
Show resolved
Hide resolved
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the three different messages 👍
…carloromeo/osparc-simcore into add-conversation-messages-ws-events
…carloromeo/osparc-simcore into add-conversation-messages-ws-events
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/web/server/src/simcore_service_webserver/conversations/_socketio.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/conversations/_socketio.py
Outdated
Show resolved
Hide resolved
...ices/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py
Outdated
Show resolved
Hide resolved
...ices/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py
Show resolved
Hide resolved
…carloromeo/osparc-simcore into add-conversation-messages-ws-events
|
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
bisgaard-itis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Thanks for the effort!



What do these changes do?
This PR enhances the system by sending Socket.IO events whenever conversation messages are created, updated, or deleted, moving toward an asynchronous communication model.
Related issue/s
How to test
Dev-ops
Nothing to do