Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jun 20, 2025

What do these changes do?

This PR enhances the system by sending Socket.IO events whenever conversation messages are created, updated, or deleted, moving toward an asynchronous communication model.

Related issue/s

How to test

cd simcore_service_webserver/services/web/server/
make install-dev
pytest -vv --pdb tests/unit/with_dbs/02/test_projects_conversations_handlers.py

Dev-ops

Nothing to do

@giancarloromeo giancarloromeo self-assigned this Jun 20, 2025
@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (4c80da2) to head (bd71d29).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7941      +/-   ##
==========================================
- Coverage   87.85%   84.97%   -2.89%     
==========================================
  Files        1848      692    -1156     
  Lines       71283    32717   -38566     
  Branches     1250      176    -1074     
==========================================
- Hits        62629    27801   -34828     
+ Misses       8292     4858    -3434     
+ Partials      362       58     -304     
Flag Coverage Δ
integrationtests 64.27% <67.30%> (+0.01%) ⬆️
unittests 86.81% <73.07%> (+0.35%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.04% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.56% <ø> (-13.52%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.65% <73.07%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c80da2...bd71d29. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo added this to the Engage milestone Jun 20, 2025
@giancarloromeo giancarloromeo requested a review from Copilot June 23, 2025 08:44

This comment was marked as outdated.

@giancarloromeo giancarloromeo marked this pull request as ready for review June 23, 2025 08:53
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks.

Could you also add (in a follow up PR if you want) from what kind of action the event comes from? For now, I can assume that I'm dealing with a new message (added), but in the future we will also need to handle edited and deleted messages.

@giancarloromeo giancarloromeo requested a review from Copilot June 23, 2025 14:12
@giancarloromeo giancarloromeo requested a review from pcrespov June 23, 2025 14:34
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the three different messages 👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@giancarloromeo giancarloromeo enabled auto-merge (squash) June 24, 2025 08:58
@giancarloromeo giancarloromeo disabled auto-merge June 24, 2025 08:58
…carloromeo/osparc-simcore into add-conversation-messages-ws-events
@giancarloromeo giancarloromeo enabled auto-merge (squash) June 24, 2025 08:59
@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 24, 2025
@sonarqubecloud
Copy link

@giancarloromeo
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@ITISFoundation ITISFoundation deleted a comment from mergify bot Jun 24, 2025
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Thanks for the effort!

@giancarloromeo giancarloromeo merged commit dd8161e into ITISFoundation:master Jun 24, 2025
93 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants