🐛 Stopping a pipeline should not fail when it does not exist

[sanderegg]

What do these changes do?

• silence_exceptions decorator improvements:
  • was renamed to suppress_exceptions
  • now requires a reason that is logged in DEBUG level with the suppressed exception
  • can optionally take a predicate in case the exception needs to be checked
  • if the predicate raises a warning is logged and the original exception is re-raised
  • see test_exception_utils.py
• ensure that when webserver stops a non existing computational pipeline it does not raise when the computational pipeline does not exist. it is ok to have a not found error in that case and was preventing the garbage collector to properly clean trash.
• changed logging level in batch functions from warning to exception logs. These are unhandled exceptions and should be treated as such.

Related issue/s

• relates to GC gets stuck and has to be rebooted #7931

How to test

Dev-ops

[codecov]

Codecov Report

Attention: Patch coverage is 94.02985% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.92%. Comparing base (8116821) to head (c92c2ac).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7942      +/-   ##
==========================================
- Coverage   88.01%   87.92%   -0.10%     
==========================================
  Files        1846     1428     -418     
  Lines       71227    59391   -11836     
  Branches     1222      624     -598     
==========================================
- Hits        62693    52220   -10473     
+ Misses       8180     6961    -1219     
+ Partials      354      210     -144     

Flag	Coverage Δ
integrationtests	64.26% <81.48%> (+0.05%)	⬆️
unittests	86.23% <94.02%> (-0.38%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	72.61% <96.96%> (+0.08%)	⬆️
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.05% <ø> (ø)
agent	96.29% <ø> (ø)
api_server	92.31% <100.00%> (ø)
autoscaling	96.03% <ø> (ø)
catalog	92.29% <ø> (ø)
clusters_keeper	99.13% <ø> (ø)
dask_sidecar	91.79% <ø> (ø)
datcore_adapter	97.94% <ø> (ø)
director	76.73% <ø> (ø)
director_v2	91.17% <100.00%> (+0.05%)	⬆️
dynamic_scheduler	96.69% <ø> (ø)
dynamic_sidecar	90.09% <100.00%> (ø)
efs_guardian	89.65% <ø> (ø)
invitations	93.00% <100.00%> (ø)
payments	92.57% <100.00%> (ø)
resource_usage_tracker	89.00% <100.00%> (-0.06%)	⬇️
storage	87.53% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	87.63% <87.50%> (-0.05%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8116821...c92c2ac. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sanderegg]

@mergify queue

[mergify]

queue

🟠 Waiting for conditions to match

• -closed [📌 queue requirement]
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • label!=🤖-do-not-merge
    • label=🤖-automerge
    • any of: [🛡 GitHub branch protection]
      • check-skipped = deploy to dockerhub
      • check-neutral = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-success = system-tests
      • check-neutral = system-tests
      • check-skipped = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = unit-tests
      • check-neutral = unit-tests
      • check-skipped = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = check OAS' are up to date
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-success = integration-tests
      • check-neutral = integration-tests
      • check-skipped = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = build-test-images (frontend) / build-test-images
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud