Make function API access rights non nullable π ποΈ #8022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
added
a:database
Contributor
Author
|
@matusdrobuliak66 Maybe check carefully if the migration script might not cause problem. (I don't think so). And I guess during deployment, if some of these fields are null (which they shouldn't), it could cause a migration issue. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #8022 +/- ##
==========================================
+ Coverage 87.88% 90.01% +2.12%
==========================================
Files 1853 1542 -311
Lines 71478 60931 -10547
Branches 1258 547 -711
==========================================
- Hits 62820 54847 -7973
+ Misses 8294 5940 -2354
+ Partials 364 144 -220
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
Contributor
Author
|
@mergify queue |
Contributor
β The pull request has been merged automaticallyThe pull request has been merged automatically at 7d6abf5 |
Contributor
Author
|
@mergify update |
Contributor
βοΈ Nothing to do, the required conditions are not met
|
pcrespov
reviewed
Jul 1, 2025
...mcore_postgres_database/migration/versions/d159ac30983c_make_func_api_access_non_nullable.py
Show resolved
Hide resolved
pcrespov
approved these changes
Jul 1, 2025
...mcore_postgres_database/migration/versions/d159ac30983c_make_func_api_access_non_nullable.py
Show resolved
Hide resolved
|
Contributor
Author
|
@mergify refresh |
Contributor
β Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As reported by @matusdrobuliak66, function API access rights were nullable, which should not be the case.
Related issue/s
Fixes #7966
How to test
Try to set function api access right to null.
Dev-ops