Skip to content

Make function API access rights non nullable 🐛 🗃️ #8022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2025
Merged

Make function API access rights non nullable 🐛 🗃️ #8022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb5681c
Disable nullable in funcapi api access rights table
wvangeit Jul 1, 2025
4e432c8
Add db migration script to make funcapi access non-nullable
wvangeit Jul 1, 2025
da5a053
Merge branch 'master' into disable_funcapi_nullable
wvangeit Jul 1, 2025
e3bd5ee
Make sure nulled api function rights are set to false
wvangeit Jul 1, 2025
d3e474d
Merge branch 'disable_funcapi_nullable' of github.com:wvangeit/osparc…
wvangeit Jul 1, 2025
2cef312
Merge branch 'master' into disable_funcapi_nullable
wvangeit Jul 1, 2025
7b86739
Merge branch 'master' into disable_funcapi_nullable
wvangeit Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 191 additions & 0 deletions ...re_postgres_database/migration/versions/d159ac30983c_make_func_api_access_non_nullable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
"""Make func api access non-nullable

Revision ID: d159ac30983c
Revises: 4f6fd2586491
Create Date: 2025-07-01 08:50:29.095068+00:00

"""

import sqlalchemy as sa
from alembic import op

# revision identifiers, used by Alembic.
revision = "d159ac30983c"
down_revision = "4f6fd2586491"
branch_labels = None
depends_on = None


def upgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET read_functions = false
WHERE read_functions IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET write_functions = false
WHERE write_functions IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET execute_functions = false
WHERE execute_functions IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET read_function_jobs = false
WHERE read_function_jobs IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET write_function_jobs = false
WHERE write_function_jobs IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET execute_function_jobs = false
WHERE execute_function_jobs IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET read_function_job_collections = false
WHERE read_function_job_collections IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET write_function_job_collections = false
WHERE write_function_job_collections IS NULL
"""
)
op.execute(
"""
UPDATE funcapi_group_api_access_rights
SET execute_function_job_collections = false
WHERE execute_function_job_collections IS NULL
"""
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_functions",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"execute_functions",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"read_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"execute_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"read_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=False,
)
op.alter_column(
"funcapi_group_api_access_rights",
"execute_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=False,
)
# ### end Alembic commands ###


def downgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.alter_column(
"funcapi_group_api_access_rights",
"execute_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"read_function_job_collections",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"execute_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"read_function_jobs",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"execute_functions",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"write_functions",
existing_type=sa.BOOLEAN(),
nullable=True,
)
op.alter_column(
"funcapi_group_api_access_rights",
"read_functions",
existing_type=sa.BOOLEAN(),
nullable=True,
)
# ### end Alembic commands ###
9 changes: 9 additions & 0 deletions ...postgres-database/src/simcore_postgres_database/models/funcapi_api_access_rights_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,46 +36,55 @@
"read_functions",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"write_functions",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"execute_functions",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"read_function_jobs",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"write_function_jobs",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"execute_function_jobs",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"read_function_job_collections",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"write_function_job_collections",
sa.Boolean,
default=False,
nullable=False,
),
sa.Column(
"execute_function_job_collections",
sa.Boolean,
default=False,
nullable=False,
),
column_created_datetime(),
column_modified_datetime(),
Expand Down
Loading