Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jul 1, 2025

What do these changes do?

  • 🎨 Introduce grouping of multiple jobs in Task Manager (Multiport Simulation use case) (πŸ—ƒοΈ)

    • 2 new endpoints:
      • ✨ /computation-collection-runs
      • ✨ /computation-collection-runs/{collection_run_id}/tasks
  • ✨ Impact on Sim4Life users:

    • When users run a multiport simulation, it will now appear as a single run in the activity overview, even though on the backend it is still implemented as eight separate projects, each with its own run.
    • The naming of runs (e.g., EM Simulation) and tasks (e.g., Line1) shown in Sim4Life will now be consistent with what users see in the oSPARC activity overview.

NEXT STEPS:

  • ♻️ Remove unused endpoints once the frontend has been updated to use the new ones.
  • ♻️ Remove dependency on projects_custom_metadata. The required information will instead be passed through HTTP headers (Sim4Life application update needed).
  • 🎨 Add filter to display only currently running jobs.

Related issue/s

How to test

Director-v2:

  • services/director-v2/tests/unit/with_dbs/comp_scheduler/test_db_repositories_comp_runs_snapshot_tasks.py
  • services/director-v2/tests/unit/with_dbs/comp_scheduler/test_db_repositories_comp_runs.py
  • services/director-v2/tests/unit/with_dbs/comp_scheduler/test_api_rpc_computations.py

Webserver:

  • services/web/server/tests/unit/with_dbs/01/test_director_v2_handlers.py

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 1, 2025
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Jul 1, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jul 1, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Introduce grouping multiple jobs in task manager (Multiport similation usecase) 🎨 Introduce grouping multiple jobs in task manager (Multiport similation usecase) (πŸ—ƒοΈ) Jul 1, 2025
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 84.39024% with 64 lines in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (00b3d1d) to head (928a70e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8025      +/-   ##
==========================================
+ Coverage   88.14%   88.22%   +0.07%     
==========================================
  Files        1811     1863      +52     
  Lines       69754    71964    +2210     
  Branches     1258     1261       +3     
==========================================
+ Hits        61488    63490    +2002     
- Misses       7903     8110     +207     
- Partials      363      364       +1     
Flag Coverage Ξ”
integrationtests 64.22% <47.49%> (-0.11%) ⬇️
unittests 86.85% <84.14%> (+0.11%) ⬆️
Components Coverage Ξ”
api 76.84% <ΓΈ> (ΓΈ)
pkg_aws_library 93.93% <ΓΈ> (ΓΈ)
pkg_celery_library 87.15% <ΓΈ> (ΓΈ)
pkg_dask_task_models_library 79.62% <ΓΈ> (ΓΈ)
pkg_models_library 93.24% <91.57%> (-0.04%) ⬇️
pkg_notifications_library 85.26% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.22% <100.00%> (+0.02%) ⬆️
pkg_service_integration 69.92% <ΓΈ> (ΓΈ)
pkg_service_library 71.25% <0.00%> (-0.17%) ⬇️
pkg_settings_library 90.64% <ΓΈ> (ΓΈ)
pkg_simcore_sdk 84.99% <ΓΈ> (-0.12%) ⬇️
agent 96.29% <ΓΈ> (ΓΈ)
api_server 92.83% <ΓΈ> (ΓΈ)
autoscaling 96.03% <ΓΈ> (ΓΈ)
catalog 92.58% <ΓΈ> (ΓΈ)
clusters_keeper 99.13% <ΓΈ> (ΓΈ)
dask_sidecar 91.79% <ΓΈ> (-0.57%) ⬇️
datcore_adapter 97.94% <ΓΈ> (ΓΈ)
director 76.73% <ΓΈ> (ΓΈ)
director_v2 91.00% <93.54%> (+0.02%) ⬆️
dynamic_scheduler 96.69% <ΓΈ> (ΓΈ)
dynamic_sidecar 90.09% <ΓΈ> (ΓΈ)
efs_guardian 89.65% <ΓΈ> (ΓΈ)
invitations 93.60% <ΓΈ> (ΓΈ)
payments 92.57% <ΓΈ> (ΓΈ)
resource_usage_tracker 92.52% <ΓΈ> (βˆ…)
storage 86.81% <ΓΈ> (+0.33%) ⬆️
webclient βˆ… <ΓΈ> (βˆ…)
webserver 88.50% <81.06%> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 00b3d1d...928a70e. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 3, 2025 14:24
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Matus, thanks!

What would the meta-modelers need to do so that iterations show up grouped?

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2025

queue

πŸ›‘ The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@matusdrobuliak66 matusdrobuliak66 added the πŸ€–-automerge marks PR as ready to be merged for Mergify label Jul 4, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. please check the suggestions.

@matusdrobuliak66 matusdrobuliak66 disabled auto-merge July 4, 2025 15:19
@matusdrobuliak66 matusdrobuliak66 added πŸ€–-do-not-merge (optional) blocks Mergify from merging the PR and removed πŸ€–-automerge marks PR as ready to be merged for Mergify labels Jul 4, 2025
@matusdrobuliak66 matusdrobuliak66 added πŸ€–-automerge marks PR as ready to be merged for Mergify and removed πŸ€–-do-not-merge (optional) blocks Mergify from merging the PR labels Jul 4, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) July 4, 2025 15:48
matusdrobuliak66 and others added 4 commits July 7, 2025 11:43
…ct-grouping-for-task-manager' of github.com:matusdrobuliak66/osparc-simcore into add-project-grouping-for-task-manager
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@matusdrobuliak66 matusdrobuliak66 merged commit 961ad38 into ITISFoundation:master Jul 7, 2025
148 of 151 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants