-
Notifications
You must be signed in to change notification settings - Fork 32
✨ [Frontend] Update to new collection runs #8074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adapts the frontend to the backend’s new grouping of runs under a collectionRunId, replaces usages of projectUuid/studyId with projectId/collectionRunId, and adds conditional visibility for the Cancel and Info buttons.
- Replace
projectUuidandstudyIdwithprojectIdandcollectionRunIdthroughout models, tables, and stores - Update resource endpoints and fetching logic to use the new
computation-collection-runsAPIs - Introduce
shouldShowFncallbacks to conditionally render Cancel and Info buttons based on run state and available info
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ImageButtonRenderer.js | Added shouldShowFn and override to conditionally render buttons |
| Jobs.js | Refactored job store methods to use projectId/collectionRunId |
| SubRunsTableModel.js | Renamed projectUuid property to collectionRunId |
| SubRunsTable.js | Updated columns and action handlers to use collectionRunId and name |
| SubRunsBrowser.js | Renamed setProject to setCollectionRun and updated instantiation |
| RunsTableModel.js | Removed includeChildren, replaced projectUuid with projectId |
| RunsTable.js | Renamed columns, added conditional renderers, updated cancel logic for multiple IDs |
| RunsBrowser.js | Removed includeChildren argument, adjusted RunsTable constructor |
| ActivityOverview.js | Switched to collectionRunId in selection and table instantiation |
| ActivityCenterWindow.js | Updated handler to call setCollectionRun |
| SubJob.js | Added collectionRunId property and renamed nodeName to name |
| Resources.js | Updated endpoints to use /computation-collection-runs and tasks URL |
| Job.js | Replaced projectUuid/projectName with collectionRunId, projectIds, and name |
Comments suppressed due to low confidence (3)
services/static-webserver/client/source/class/osparc/jobs/RunsBrowser.js:87
- [nitpick] The variable is named
projectUuidbut is passed as the newprojectIdparameter inRunsTable. Consider renaming this local variable toprojectIdfor clarity and consistency.
const projectUuid = null;
services/static-webserver/client/source/class/osparc/jobs/RunsTable.js:235
- [nitpick] When cancelling multiple pipelines at once, the message "Stopping Run" may be misleading (singular). Consider using a plural or more descriptive message (e.g., "Stopping Runs") to reflect the batch operation.
.then(() => osparc.FlashMessenger.logAs(this.tr("Stopping Run"), "INFO"))
services/static-webserver/client/source/class/osparc/ui/table/cellrenderer/ImageButtonRenderer.js:44
- The new
shouldShowFnconditional rendering behavior increateDataCellHtmlshould be covered by unit or integration tests to ensure the button visibility logic works correctly in all cases.
createDataCellHtml: function(cellInfo, htmlArr) {
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4c5a0f3 |
|



What do these changes do?
This PR adapts the frontend to the new way the backend groups the runs.
As bonus, the Cancel button at the Collection Run level (which will cancel all the
projectIdsprovided in the run), will only be visible if its state isRunningand the info button will only be visible if there is any info available.Related issue/s
How to test
Dev-ops