Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 8, 2025

What do these changes do?

  • ensures that director-v0 exception are enveloped such that the catalog can handle them

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 8, 2025
@sanderegg sanderegg self-assigned this Jul 8, 2025
@sanderegg sanderegg requested review from GitHK and pcrespov as code owners July 8, 2025 16:39
@sanderegg sanderegg added a:director issue related with the director service t:maintenance Some planned maintenance work labels Jul 8, 2025
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 8, 2025
@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.51%. Comparing base (7c68dc8) to head (2e8bf7c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7c68dc8) and HEAD (2e8bf7c). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (7c68dc8) HEAD (2e8bf7c)
unittests 32 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8081       +/-   ##
===========================================
- Coverage   88.27%   68.51%   -19.77%     
===========================================
  Files        1856      765     -1091     
  Lines       71771    36057    -35714     
  Branches     1262      176     -1086     
===========================================
- Hits        63357    24705    -38652     
- Misses       8049    11294     +3245     
+ Partials      365       58      -307     
Flag Coverage Δ
integrationtests 64.22% <ø> (-0.06%) ⬇️
unittests 86.76% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.92% <ø> (-8.13%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 92.58% <100.00%> (ø)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 76.86% <100.00%> (+0.13%) ⬆️
director_v2 77.36% <ø> (-13.64%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.00% <ø> (-29.60%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c68dc8...2e8bf7c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 9, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at aa0cd2f

@sanderegg sanderegg force-pushed the bugfix/envelope-director-v0-error-responses branch from da8cc33 to 2e8bf7c Compare July 9, 2025 06:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify mergify bot merged commit aa0cd2f into ITISFoundation:master Jul 9, 2025
146 of 151 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director issue related with the director service t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants