✨ [Frontend] Functions Browser #8116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Functions Browser feature for the frontend that allows users to view and manage functions created from project templates. The implementation includes both the data layer for function management and the UI components for browsing functions in the dashboard.
- Adds comprehensive Functions store and data model infrastructure
- Implements Functions browser UI with filtering, cards, and details view
- Integrates function support into existing dashboard and workbench components
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
osparc/store/Functions.js |
New store for function CRUD operations and data management |
osparc/data/model/Function.js |
New data model for function entities |
osparc/dashboard/StudyBrowser.js |
Adds Functions context and browsing capabilities |
osparc/dashboard/ResourceBrowserFilter.js |
Adds Functions filter button to sidebar |
osparc/dashboard/ResourceDetails.js |
Integrates function details view |
osparc/info/FunctionLarge.js |
New function information display component |
osparc/workbench/WorkbenchUI.js |
Refactors constants and adds property initialization check |
osparc/widget/PersistentIframe.js |
Updates function opening logic for new/old versions |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js:696
- [nitpick] The method name changed from 'updateTutorialData' to '_updateTutorialData' but this appears to be inconsistent with other similar methods in the class.
_updateTutorialData: function(tutorialData) {
services/static-webserver/client/source/class/osparc/store/Functions.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/Function.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/FunctionLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/FunctionLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/FunctionLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/FunctionLarge.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/StudyPreview.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/store/Functions.js
Outdated
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov,
sanderegg and
wvangeit
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
matusdrobuliak66
approved these changes
Jul 17, 2025
sanderegg
approved these changes
Jul 17, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
nice! you might want a list view as well.
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9b06506 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR brings the first iteration on the Functions Browser. It includes both the data layer for function management and the UI components for browsing functions in the dashboard.
As discussed, there is a Functions section between the Public Projects and Trash, And the functions coming from the backend will be represented with cards there. When the user clicks on a card, a window is popped up and its metadata is shown in the overview section.
Next steps, once the backend provides the required:
template_id, add also the pipeline view to the pop up windownameanddescriptionRelated issue/s
How to test
Dev-ops