Skip to content

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 16, 2025

What do these changes do?

This PR enhances the Functions REST API endpoints in the Web Server by adding support for listing and updating functions. The changes enable full CRUD operations for function management.

  • Added list functions endpoint with pagination and query parameters for enhanced functionality
  • Added update function endpoint to allow modification of function titles and descriptions
  • Enhanced existing get function endpoint with query parameters for including extra metadata like thumbnails

Related issue/s

How to test

cd services/web/server
pytest -vv --pdb tests/unit/with_dbs/04/functions_rpc

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jul 16, 2025
@giancarloromeo giancarloromeo self-assigned this Jul 16, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 16, 2025
@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 64.77273% with 31 lines in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (2b9bf2b) to head (38ebf35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8117      +/-   ##
==========================================
+ Coverage   89.74%   89.81%   +0.07%     
==========================================
  Files        1701     1454     -247     
  Lines       66121    60299    -5822     
  Branches      819      491     -328     
==========================================
- Hits        59341    54160    -5181     
+ Misses       6566     6013     -553     
+ Partials      214      126      -88     
Flag Coverage Δ
integrationtests 64.14% <40.27%> (-0.02%) ⬇️
unittests 88.15% <64.77%> (-0.10%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.16% <100.00%> (+0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (+0.05%) ⬆️
agent 93.81% <ø> (ø)
api_server 93.02% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (+0.22%) ⬆️
datcore_adapter ∅ <ø> (∅)
director 76.14% <ø> (ø)
director_v2 91.04% <ø> (+0.08%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations ∅ <ø> (∅)
payments 92.60% <ø> (ø)
resource_usage_tracker 91.80% <ø> (-0.80%) ⬇️
storage 86.39% <ø> (-0.34%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.15% <56.94%> (-0.05%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9bf2b...38ebf35. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title 🎨 Add functions REST API endpoints in web-server 🎨 Enhance Functions REST API endpoints in Web Server Jul 16, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 22, 2025
@giancarloromeo
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@giancarloromeo giancarloromeo enabled auto-merge (squash) July 22, 2025 07:40
@giancarloromeo giancarloromeo added 🤖-do-not-merge (optional) blocks Mergify from merging the PR and removed 🤖-automerge marks PR as ready to be merged for Mergify labels Jul 22, 2025
@giancarloromeo giancarloromeo disabled auto-merge July 22, 2025 08:05
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo added 🤖-automerge marks PR as ready to be merged for Mergify and removed 🤖-do-not-merge (optional) blocks Mergify from merging the PR labels Jul 22, 2025
@giancarloromeo giancarloromeo enabled auto-merge (squash) July 22, 2025 10:20
@giancarloromeo giancarloromeo merged commit abfb431 into ITISFoundation:master Jul 22, 2025
142 of 150 checks passed
@giancarloromeo giancarloromeo deleted the is1905/add-new-fuctions-rest-api-endpoints branch July 22, 2025 11:06
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance Functions REST API in Web Server

6 participants