- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
♻️ Refactors studies-dispatcher before extending nih portal's views api (🚨) #8257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactors studies-dispatcher before extending nih portal's views api (🚨) #8257
Conversation
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@           Coverage Diff           @@
##           master    #8257   +/-   ##
=======================================
  Coverage   87.82%   87.83%           
=======================================
  Files        1940     1945    +5     
  Lines       75317    75369   +52     
  Branches     1311     1311           
=======================================
+ Hits        66146    66198   +52     
  Misses       8776     8776           
  Partials      395      395           
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
ce53e6b    to
    3c3f8c0      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
        
          
                services/web/server/src/simcore_service_webserver/studies_dispatcher/_redirects_handlers.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/studies_dispatcher/settings.py
          
            Show resolved
            Hide resolved
        
      9a75ca1    to
    622f24f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
c78aca4    to
    3978eab      
    Compare
  
    | 
           @mergify queue  | 
    
          
 🟠 Waiting for conditions to match
  | 
    
          
 | 
    
| 
           🚨 checked in master. OK  | 
    
| 
           🚨 checked in aws-staging. OK  | 
    
| 
           🚨 checked in aws-production (using testing endpoint. OK  | 
    



What do these changes do?
Before adding a new redirection
/view/manifest, here are some improvements of viewer dispatcher API that we discovered while checking the functionality:Related issue/s
How to test
Dev-ops
🚨 check portal e2e links on each deploy