🎨Autoscaling: warm buffers: create at minimum 1 machine at a time instead of asking directly for the required number #8262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:autoscaling
sanderegg
force-pushed
the
autoscaling/create-1-warmbuffer-at-a-time
branch
from
a83d521 to
c39da4f
Compare
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the reliability of warm buffer machine creation in the autoscaling service by modifying the EC2 instance creation strategy. Instead of requiring AWS to create all requested machines in a single batch (which could fail if resources are limited), it now allows AWS to create machines incrementally, starting with at least 1 machine at a time.
- Changes the minimum instance creation requirement from N machines to 1 machine
- Maintains the desired total number of machines while allowing for more flexible provisioning
sanderegg
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
mguidon and
pcrespov
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8262 +/- ##
===========================================
- Coverage 88.03% 68.45% -19.59%
===========================================
Files 1919 781 -1138
Lines 74341 36587 -37754
Branches 1305 175 -1130
===========================================
- Hits 65449 25047 -40402
- Misses 8499 11483 +2984
+ Partials 393 57 -336
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for ff30fe6. ✅ Passed Jobs With Interesting Signals
|
sanderegg
changed the title
…m:sanderegg/osparc-simcore into autoscaling/create-1-warmbuffer-at-a-time
|
giancarloromeo
approved these changes
Aug 26, 2025
matusdrobuliak66
approved these changes
Aug 26, 2025
GitHK
approved these changes
Aug 26, 2025
...g/src/simcore_service_autoscaling/modules/cluster_scaling/_warm_buffer_machines_pool_core.py
Show resolved
Hide resolved
pcrespov
approved these changes
Aug 26, 2025
14 tasks
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
While working on #8099 and after setting once a lot of warm buffer machines, it was discovered that the warm buffer background task is not creating machines in a reliable way.
The EC2 interface allows to create a number of instances between a
minimumand amaximumand the warm buffers were created always with both set to the same number. That means that if one would ask for 20 warm buffers suddenly EC2 would have to create 1 batch of 20.This PR changes this to ask between 1 and N machines. Therefore if AWS can provide 1 machine at a time it will work as well.
Related issue/s
How to test
Dev-ops