Skip to content

🎨Autoscaling: warm buffers: create at minimum 1 machine at a time instead of asking directly for the required number #8262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2025
Merged

🎨Autoscaling: warm buffers: create at minimum 1 machine at a time instead of asking directly for the required number #8262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a83d521
the fix
sanderegg Aug 26, 2025
c39da4f
the fix
sanderegg Aug 26, 2025
919647a
patch calls
sanderegg Aug 26, 2025
ff30fe6
Merge branch 'autoscaling/create-1-warmbuffer-at-a-time' of github.co…
sanderegg Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/simcore_service_autoscaling/modules/cluster_scaling/_warm_buffer_machines_pool_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ async def _add_remove_buffer_instances(
subnet_id=app_settings.AUTOSCALING_EC2_INSTANCES.EC2_INSTANCES_SUBNET_ID,
iam_instance_profile=app_settings.AUTOSCALING_EC2_INSTANCES.EC2_INSTANCES_ATTACHED_IAM_PROFILE,
),
min_number_of_instances=num_to_start,
min_number_of_instances=1, # NOTE: we want at least 1
number_of_instances=num_to_start,
max_total_number_of_instances=app_settings.AUTOSCALING_EC2_INSTANCES.EC2_INSTANCES_MAX_INSTANCES,
)
Expand Down
3 changes: 3 additions & 0 deletions services/autoscaling/tests/unit/test_modules_cluster_scaling_warm_buffer_machine_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ async def _assert_wait_for_ssm_command_to_finish() -> None:


async def test_monitor_buffer_machines(
patch_ec2_client_launch_instances_min_number_of_instances: None,
minimal_configuration: None,
ec2_client: EC2Client,
buffer_count: int,
Expand Down Expand Up @@ -374,6 +375,7 @@ async def test_monitor_buffer_machines_terminates_supernumerary_instances(


async def test_monitor_buffer_machines_terminates_instances_with_incorrect_pre_pulled_images(
patch_ec2_client_launch_instances_min_number_of_instances: None,
minimal_configuration: None,
ec2_client: EC2Client,
buffer_count: int,
Expand Down Expand Up @@ -457,6 +459,7 @@ def unneeded_instance_type(
],
)
async def test_monitor_buffer_machines_terminates_unneeded_pool(
patch_ec2_client_launch_instances_min_number_of_instances: None,
minimal_configuration: None,
ec2_client: EC2Client,
buffer_count: int,
Expand Down
Loading