Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 23, 2025

What do these changes do?

  • 🐛 Adds user to project rooms on websocket reconnect

Related issue/s

How to test

Dev-ops

Ensures users are automatically added to socket rooms for projects they have open when connecting, improving real-time collaboration and state synchronization across project sessions.
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver webserver's codebase. Assigning the area is particularly useful for bugs labels Sep 23, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Cheops milestone Sep 23, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 Adds user assignment to project rooms on websocket reconnect 🐛 Adds user to project rooms on websocket reconnect Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.80%. Comparing base (562497c) to head (cdc968e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8407      +/-   ##
==========================================
- Coverage   87.90%   84.80%   -3.10%     
==========================================
  Files        1951      761    -1190     
  Lines       75967    35050   -40917     
  Branches     1336      175    -1161     
==========================================
- Hits        66778    29725   -37053     
+ Misses       8790     5268    -3522     
+ Partials      399       57     -342     
Flag Coverage Δ
integrationtests 63.98% <80.00%> (+0.03%) ⬆️
unittests 87.23% <90.00%> (+0.65%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.80% <ø> (-8.19%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.11% <ø> (-12.79%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.01% <90.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562497c...cdc968e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2025

🧪 CI Insights

Here's what we observed from your CI run for cdc968e.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 23, 2025 14:55
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@matusdrobuliak66 matusdrobuliak66 merged commit 9461e3d into ITISFoundation:master Sep 23, 2025
143 of 148 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants