Skip to content

🐛 Adds user to project rooms on websocket reconnect #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

🐛 Adds user to project rooms on websocket reconnect #8407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion services/web/server/src/simcore_service_webserver/socketio/_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from common_library.logging.logging_errors import create_troubleshooting_log_kwargs
from models_library.api_schemas_webserver.socketio import SocketIORoomStr
from models_library.products import ProductName
from models_library.projects import ProjectID
from models_library.socketio import SocketMessageDict
from models_library.users import UserID
from pydantic import TypeAdapter
Expand All @@ -23,7 +24,7 @@
from ..groups.api import list_user_groups_ids_with_read_access
from ..login.decorators import login_required
from ..products import products_web
from ..resource_manager.user_sessions import managed_resource
from ..resource_manager.user_sessions import PROJECT_ID_KEY, managed_resource
from ._utils import EnvironDict, SocketID, get_socket_server, register_socketio_handler
from .messages import SOCKET_IO_HEARTBEAT_EVENT, send_message_to_user

Expand Down Expand Up @@ -99,6 +100,21 @@ async def _set_user_in_group_rooms(
await sio.enter_room(socket_id, SocketIORoomStr.from_user_id(user_id))


async def _set_user_in_project_rooms(
app: web.Application, user_id: UserID, client_session_id: str, socket_id: SocketID
) -> None:
"""Adds user in project rooms in case he has any project open"""
project_ids = []
with managed_resource(user_id, client_session_id, app) as user_session:
project_ids = await user_session.find_all_resources_of_user(PROJECT_ID_KEY)

sio = get_socket_server(app)
for project_id in project_ids:
await sio.enter_room(
socket_id, SocketIORoomStr.from_project_id(ProjectID(project_id))
)


#
# socketio event handlers
#
Expand Down Expand Up @@ -135,6 +151,7 @@ async def connect(
)

await _set_user_in_group_rooms(app, user_id, socket_id)
await _set_user_in_project_rooms(app, user_id, client_session_id, socket_id)

_logger.debug("Sending set_heartbeat_emit_interval with %s", _EMIT_INTERVAL_S)

Expand Down
Loading