Skip to content

🎨 [Support center] reopen closed Fogbugz cases (πŸ—ƒοΈ) #8482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 13, 2025
Merged

🎨 [Support center] reopen closed Fogbugz cases (πŸ—ƒοΈ) #8482

merged 18 commits into from
Oct 13, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Oct 8, 2025 •
edited
Loading

What do these changes do?

Follow up on Support Center feature:

  • [ ] Add Fogbugz status in GET conversation model
  • By default list conversations by last modified field
    • When new message is created update last modified field in Conversations
  • Add Read By User boolean flag to CONVERSATION model (πŸ—ƒοΈ)
    • if it comes from the user its True
    • if it comes from the support/AI its False
    • Allow frontend to Patch this field
  • Add Read By Support User boolean flag to CONVERSATION model (πŸ—ƒοΈ)
  • Reopen Fogbugz case in case it was closed and new message is added
  • Add product filtering in list_all_support_conversations_for_support_user
  • Add Fogbugz basic retry functionality

NOTE: We introduced read by support flag, so we do not need to pass the Fogbugz status / store it in our DB and keep it in sync

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 8, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Oct 8, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Cheops milestone Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 54.28571% with 48 lines in your changes missing coverage. Please review.
βœ… Project coverage is 89.52%. Comparing base (3ca1fb6) to head (70d9a03).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8482      +/-   ##
==========================================
+ Coverage   87.29%   89.52%   +2.23%     
==========================================
  Files        1925     1695     -230     
  Lines       75417    67377    -8040     
  Branches     1338      639     -699     
==========================================
- Hits        65835    60322    -5513     
+ Misses       9182     6885    -2297     
+ Partials      400      170     -230
Flag Coverage Ξ”
integrationtests 64.04% <16.66%> (-0.05%) ⬇️
unittests 88.02% <54.28%> (+2.07%) ⬆️
Components Coverage Ξ”
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_celery_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 93.08% <100.00%> (+0.01%) ⬆️
pkg_notifications_library 85.20% <ΓΈ> (ΓΈ)
pkg_postgres_database 87.95% <ΓΈ> (ΓΈ)
pkg_service_integration 70.17% <ΓΈ> (ΓΈ)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 84.89% <ΓΈ> (ΓΈ)
agent 93.10% <ΓΈ> (ΓΈ)
api_server 91.86% <ΓΈ> (ΓΈ)
autoscaling 95.72% <ΓΈ> (ΓΈ)
catalog 92.06% <ΓΈ> (ΓΈ)
clusters_keeper 99.14% <ΓΈ> (ΓΈ)
dask_sidecar 92.38% <ΓΈ> (ΓΈ)
datcore_adapter 97.95% <ΓΈ> (ΓΈ)
director 75.72% <ΓΈ> (ΓΈ)
director_v2 90.93% <ΓΈ> (-0.03%) ⬇️
dynamic_scheduler 96.82% <ΓΈ> (βˆ…)
dynamic_sidecar 90.44% <ΓΈ> (-0.03%) ⬇️
efs_guardian 89.83% <ΓΈ> (ΓΈ)
invitations 90.90% <ΓΈ> (ΓΈ)
payments 92.80% <ΓΈ> (ΓΈ)
resource_usage_tracker 92.16% <ΓΈ> (-0.06%) ⬇️
storage 86.41% <ΓΈ> (+0.20%) ⬆️
webclient βˆ… <ΓΈ> (βˆ…)
webserver 87.22% <46.66%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3ca1fb6...70d9a03. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025 •
edited
Loading

πŸ§ͺ CI Insights

Here's what we observed from your CI run for 70d9a03.

βœ… Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries πŸ” CI Insights πŸ“„ Logs
CI system-tests Base branch is broken, but retries were needed. Could be early signs of flakiness πŸ‘€ Broken 1 View View

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 10, 2025 15:15
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 [Support center] reopen closed Fogbugz cases 🎨 [Support center] reopen closed Fogbugz cases (πŸ—ƒοΈ) Oct 10, 2025
odeimaiz
odeimaiz approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock&Roll πŸš€

pcrespov
pcrespov approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Left you some suggestions. We should follow up a bit offline. In the meantime i do not want to block this. thx

bisgaard-itis
bisgaard-itis approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the effort

GitHK
GitHK approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good Matus, just some questions.

sanderegg
sanderegg approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 13, 2025 11:48
@matusdrobuliak66
Copy link
Collaborator Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [πŸ“Œ queue requirement]
  • -conflict [πŸ“Œ queue requirement]
  • -draft [πŸ“Œ queue requirement]
  • any of: [πŸ“Œ queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [πŸ”€ queue conditions]
    • all of: [πŸ“Œ queue conditions of queue default]
      • #approved-reviews-by >= 2 [πŸ›‘ GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [πŸ›‘ GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [πŸ›‘ GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [πŸ›‘ GitHub branch protection]
      • label!=πŸ€–-do-not-merge
      • label=πŸ€–-automerge
      • any of: [πŸ›‘ GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [πŸ›‘ GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@matusdrobuliak66 matusdrobuliak66 added the πŸ€–-automerge marks PR as ready to be merged for Mergify label Oct 13, 2025
@matusdrobuliak66 matusdrobuliak66 merged commit 7aa3ac8 into ITISFoundation:master Oct 13, 2025
144 of 148 checks passed
This was referenced Oct 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

6 participants

@matusdrobuliak66 @GitHK @pcrespov @odeimaiz @sanderegg @bisgaard-itis