Skip to content

🐛 Prevent showing full s3 url with credentials in logs #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2025
Merged

🐛 Prevent showing full s3 url with credentials in logs #8493

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a702e00
Remove query from url when logging
wvangeit Oct 9, 2025
bc448a5
Merge branch 'master' into obfuscate_aws_cred
wvangeit Oct 9, 2025
c22730f
Merge branch 'master' into obfuscate_aws_cred
wvangeit Oct 9, 2025
78565da
Merge branch 'master' into obfuscate_aws_cred
wvangeit Oct 10, 2025
ed711ad
Merge branch 'master' into obfuscate_aws_cred
wvangeit Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions services/dask-sidecar/src/simcore_service_dask_sidecar/utils/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ async def pull_file_from_remote(
s3_settings: S3Settings | None,
) -> None:
assert src_url.path # nosec
src_location_str = f"{src_url.path.strip('/')} on {src_url.host}:{src_url.port}"
await log_publishing_cb(
f"Downloading '{src_url}' into local file '{dst_path}'...",
f"Downloading '{src_location_str}' into local file '{dst_path}'...",
logging.INFO,
)
if not dst_path.parent.exists():
Expand Down Expand Up @@ -196,11 +197,11 @@ async def pull_file_from_remote(
TypeAdapter(FileUrl).validate_python(f"{download_dst_path.as_uri()}"),
src_storage_cfg=cast(dict[str, Any], storage_kwargs),
log_publishing_cb=log_publishing_cb,
text_prefix=f"Downloading '{src_url.path.strip('/')}':",
text_prefix=f"Downloading '{src_location_str}':",
)

await log_publishing_cb(
f"Download of '{src_url}' into local file '{download_dst_path}' complete.",
f"Download of '{src_location_str}' into local file '{download_dst_path}' complete.",
logging.INFO,
)

Expand Down
Loading