-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Prevent showing full s3 url with credentials in logs #8493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Closes #5979 |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8493 +/- ##
===========================================
- Coverage 87.62% 66.72% -20.90%
===========================================
Files 2001 795 -1206
Lines 77919 36265 -41654
Branches 1338 175 -1163
===========================================
- Hits 68273 24198 -44075
- Misses 9246 12010 +2764
+ Partials 400 57 -343
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx.
Took the liberty to modify your PR description and title to follow our https://github.com/itisfoundation/osparc-simcore/blob/3db0e34fa7d84ab431a9546f690db9d945388c96/.github/PULL_REQUEST_TEMPLATE.md
- prefix icon in the itle
- enumerate related issues so they display
- prefix issue with
closes,fixesorresolveto auto-close the references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
@mergify queue |
🟠 Waiting for conditions to match
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!



What do these changes do?
As per #5979
the logs were show urls with full credentials with downloading a file.
I changed it to only show the server and file path.
Related issue/s
How to test
Download file in service, url should not show credentials.
Dev-ops
No changes