Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Oct 10, 2025

What do these changes do?

  • Until now the permission check (2 RPC requests api-server->wb-api-server) was performed once for every created function job in the map endpoint (in case of 50 inputs that is 100 requests api-server -> wb-api-server).
  • Now the permission check is performed only once within that endpoint (2 requests). That means we remove 98 redundant requests api-server->wb-api-server when 50 inputs are submitted to the map endpoint.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Oct 10, 2025
@bisgaard-itis bisgaard-itis added this to the Cheops milestone Oct 10, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review October 10, 2025 12:05
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (aadb582) to head (6b277e3).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (aadb582) and HEAD (6b277e3). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (aadb582) HEAD (6b277e3)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8499       +/-   ##
===========================================
- Coverage   87.61%   69.04%   -18.58%     
===========================================
  Files        2001      900     -1101     
  Lines       77916    39943    -37973     
  Branches     1338      175     -1163     
===========================================
- Hits        68267    27578    -40689     
- Misses       9249    12308     +3059     
+ Partials      400       57      -343     
Flag Coverage Δ
integrationtests 64.09% <ø> (-0.01%) ⬇️
unittests 91.86% <100.00%> (+5.54%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.69% <ø> (-8.26%) ⬇️
agent ∅ <ø> (∅)
api_server 91.86% <100.00%> (-0.02%) ⬇️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.10% <ø> (-12.82%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.89% <ø> (-8.55%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.09% <ø> (-28.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aadb582...6b277e3. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

🧪 CI Insights

Here's what we observed from your CI run for 6b277e3.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit db5eb1f into ITISFoundation:master Oct 10, 2025
142 of 148 checks passed
@bisgaard-itis bisgaard-itis deleted the 8498-only-check-permission-once-in-map-endpoint branch October 10, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Only check permissions once when submitting jobs via the api-server's map endpoint.

4 participants