-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Ensure function execute permission check is performed only once in map endpoint #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Ensure function execute permission check is performed only once in map endpoint #8499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8499 +/- ##
===========================================
- Coverage 87.61% 69.04% -18.58%
===========================================
Files 2001 900 -1101
Lines 77916 39943 -37973
Branches 1338 175 -1163
===========================================
- Hits 68267 27578 -40689
- Misses 9249 12308 +3059
+ Partials 400 57 -343
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_functions.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/_service_functions.py
Show resolved
Hide resolved
|
db5eb1f
into
ITISFoundation:master



What do these changes do?
api-server->wb-api-server) was performed once for every created function job in the map endpoint (in case of 50 inputs that is 100 requestsapi-server->wb-api-server).api-server->wb-api-serverwhen 50 inputs are submitted to the map endpoint.Related issue/s
How to test
Dev-ops