π chatbot followups (ποΈ) #8541
Merged
+136
β23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8541 +/- ##
==========================================
+ Coverage 87.51% 89.38% +1.86%
==========================================
Files 2011 1687 -324
Lines 78591 67023 -11568
Branches 1349 647 -702
==========================================
- Hits 68779 59908 -8871
+ Misses 9408 6942 -2466
+ Partials 404 173 -231
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
π§ͺ CI InsightsHere's what we observed from your CI run for ea1ed49. β Passed Jobs With Interesting Signals
|
matusdrobuliak66
requested review from
GitHK,
giancarloromeo,
pcrespov and
sanderegg
as code owners
matusdrobuliak66
added
the
a:webserver
matusdrobuliak66
changed the title
GitHK
approved these changes
Oct 21, 2025
giancarloromeo
approved these changes
Oct 21, 2025
|
@mergify queue |
π Waiting for conditions to match
|
matusdrobuliak66
added
the
π€-automerge
sanderegg
approved these changes
Oct 21, 2025
5 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues related to chatbot functionality and adds support for a new conversation type. The main changes include:
- Fixed conditional logic for triggering chatbot processing (checking for REGULAR_USER instead of CHATBOT_USER)
- Added SUPPORT_CALL conversation type to support phone/call-based support conversations
- Added chatbot user primary group to /me API endpoint and group listings
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_projects_crud_handlers__delete.py | Added required base_url field to product insert |
| users_rest.py | Added product_chatbot_primary_group to user profile response |
| _groups_service.py | Added logic to retrieve and return chatbot user's primary group |
| _groups_rest.py | Updated group listing to include chatbot primary group |
| _conversation_message_service.py | Fixed chatbot trigger condition and updated log levels |
| _conversations_rest.py | Replaced direct type comparisons with is_support_type() method |
| _conversations_messages_rest.py | Replaced direct type comparisons with is_support_type() method |
| _process_chatbot_trigger_service.py | Changed log level from debug to warning for missing conversations |
| openapi.yaml | Added SUPPORT_CALL type and chatbot field to API schema |
| test_modules_db_repositories_groups_extra_properties.py | Added base_url field to product configuration |
| conversations.py | Added SUPPORT_CALL enum value |
| 5756d9282a0a_add_support_call_conversationt_ype.py | Migration file for SUPPORT_CALL type addition |
| test_users.py | Added test parameter for chatbot user group |
| groups.py | Added chatbot group to schema examples |
| conversations.py (models-library) | Added SUPPORT_CALL type and is_support_type() helper method |
| users.py | Updated MyProfile to include chatbot user group |
| groups.py (api_schemas) | Added chatbot field to MyGroupsGet schema |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...core_postgres_database/migration/versions/5756d9282a0a_add_support_call_conversationt_ype.py
Show resolved
Hide resolved
...core_postgres_database/migration/versions/5756d9282a0a_add_support_call_conversationt_ype.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Oct 21, 2025
...core_postgres_database/migration/versions/5756d9282a0a_add_support_call_conversationt_ype.py
Outdated
Show resolved
Hide resolved
...es/web/server/src/simcore_service_webserver/conversations/_controller/_conversations_rest.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/groups.py
Show resolved
Hide resolved
|
matusdrobuliak66
merged commit 13d4661
into
ITISFoundation:master
189 of 201 checks passed
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
SUPPORT_CALLtypeRelated issue/s
How to test
Dev-ops
None
Summary (AI)
This pull request introduces support for a new
SUPPORT_CALLconversation type and adds chatbot group information to the product and user schemas. It updates the backend models, API schemas, and related validation logic to handle these new features. The changes also enhance testing to cover the new chatbot group functionality.Support conversation enhancements:
SUPPORT_CALLconversation type alongside the existingSUPPORTtype in both backend models (ConversationTypeenums) and OpenAPI schemas, including a database migration stub for future support. Also introduced anis_support_type()helper method to simplify type checks. [1] [2] [3] [4]SUPPORTandSUPPORT_CALLconversation types by using the newis_support_type()method instead of direct equality checks. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Chatbot group support:
MyGroupsGet) to include a new optionalchatbotfield, with corresponding OpenAPI documentation and example data. [1] [2] [3] [4]Other improvements:
base_urlfield for products.These changes collectively enable the platform to distinguish between standard support and support call conversations, and to expose chatbot group information in the API, improving support workflows and integration options.