Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 21, 2025

What do these changes do?

  • ensure exclusive queues (queues that are auto-deleted when the connection to a client is closed) are not set as durable (survive broker crash/restart) as this is pointless: e.g. if the connection is closed then the queue is anyway closed due to exclusivity

Related issue/s

How to test

Dev-ops

⚠️ the affected queues will need to be deleted prior to deploying

@sanderegg sanderegg added this to the Imparable milestone Oct 21, 2025
@sanderegg sanderegg self-assigned this Oct 21, 2025
@sanderegg sanderegg added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.69%. Comparing base (347cf3f) to head (c7e8725).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8546       +/-   ##
===========================================
+ Coverage   71.01%   84.69%   +13.68%     
===========================================
  Files        1103     1578      +475     
  Lines       45797    65670    +19873     
  Branches      619      681       +62     
===========================================
+ Hits        32522    55621    +23099     
+ Misses      13114     9810     -3304     
- Partials      161      239       +78     
Flag Coverage Δ
integrationtests 63.88% <ø> (-0.05%) ⬇️
unittests 82.98% <ø> (-5.98%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 70.97% <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (+8.14%) ⬆️
agent 93.10% <ø> (∅)
api_server 91.62% <ø> (∅)
autoscaling 95.00% <ø> (∅)
catalog 92.06% <ø> (∅)
clusters_keeper 99.14% <ø> (∅)
dask_sidecar 91.82% <ø> (∅)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (∅)
director_v2 90.91% <ø> (+12.83%) ⬆️
dynamic_scheduler 96.66% <ø> (∅)
dynamic_sidecar 90.44% <ø> (+8.54%) ⬆️
efs_guardian 89.83% <ø> (∅)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (∅)
resource_usage_tracker 92.11% <ø> (∅)
storage 86.84% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 79.60% <ø> (+20.69%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347cf3f...c7e8725. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg marked this pull request as ready for review October 21, 2025 21:42
@sanderegg sanderegg requested a review from pcrespov as a code owner October 21, 2025 21:42
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2025

🧪 CI Insights

Here's what we observed from your CI run for c7e8725.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Healthy 0 View View

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg changed the title ♻️ RabbitMQ: Make sure exclusive queues are not set as durable ♻️ RabbitMQ: Make sure exclusive queues are not set as durable (⚠️ devops) Oct 22, 2025
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanderegg sanderegg force-pushed the rabbitmq/use-quorum-queues branch 2 times, most recently from 1fc7e33 to e4b1ce1 Compare October 24, 2025 14:07
@sanderegg sanderegg force-pushed the rabbitmq/use-quorum-queues branch from e4b1ce1 to c7e8725 Compare October 24, 2025 14:30
@sanderegg sanderegg merged commit 379e430 into ITISFoundation:master Oct 24, 2025
39 of 41 checks passed
@sanderegg sanderegg deleted the rabbitmq/use-quorum-queues branch October 24, 2025 14:31
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants