Skip to content

♻️ RabbitMQ: Make sure exclusive queues are not set as durable (⚠️ devops) #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

♻️ RabbitMQ: Make sure exclusive queues are not set as durable (⚠️ devops) #8546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad02f3
make sure exclusive queues are not marked as durable
sanderegg Oct 21, 2025
c7e8725
@YuryHrytsuk review: remove unnecessary check
sanderegg Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions packages/service-library/src/servicelib/rabbitmq/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async def declare_queue(
if arguments is not None:
default_arguments.update(arguments)
queue_parameters: dict[str, Any] = {
"durable": True,
"durable": not exclusive_queue,
"exclusive": exclusive_queue,
"arguments": default_arguments,
"name": f"{get_rabbitmq_client_unique_name(client_name)}_{queue_name}_exclusive",
Expand All @@ -85,19 +85,6 @@ async def declare_queue(
# NOTE: setting a name will ensure multiple instance will take their data here
queue_parameters |= {"name": queue_name}

# avoids deprecated `transient_nonexcl_queues` warning in RabbitMQ
if (
queue_parameters.get("durable", False) is False
and queue_parameters.get("exclusive", False) is False
):
msg = (
"Queue must be `durable` or `exclusive`, but not both. "
"This is to avoid the `transient_nonexcl_queues` warning. "
"NOTE: if both `durable` and `exclusive` are missing they are considered False. "
f"{queue_parameters=}"
)
raise ValueError(msg)

# NOTE: if below line raises something similar to ``ChannelPreconditionFailed: PRECONDITION_FAILED``
# most likely someone changed the signature of the queues (parameters etc...)
# Safest way to deal with it:
Expand Down
Loading