Add query execution utilities #18
Conversation
yhabteab
force-pushed
the
query-builder
branch
2 times, most recently
from
13775df to
9cfb220
Compare
yhabteab
force-pushed
the
icinga-notifications
branch
from
cfb45a9 to
7f3095c
Compare
yhabteab
force-pushed
the
query-builder
branch
2 times, most recently
from
474ff25 to
3e9722f
Compare
yhabteab
force-pushed
the
icinga-notifications
branch
from
7f3095c to
89805fa
Compare
| // TxOrDB is just a helper interface that can represent a *[sqlx.Tx] or *[DB] instance. | ||
| type TxOrDB interface { | ||
| sqlx.ExtContext | ||
| sqlx.PreparerContext | ||
|
|
||
| PrepareNamedContext(ctx context.Context, query string) (*sqlx.NamedStmt, error) | ||
| } |
There was a problem hiding this comment.
Also the whole thing seems just a subset of DB&Tx. I personally would unexport and move it...
There was a problem hiding this comment.
Wouldn't you also want to use this interface type elsewhere where a DB or Tx is required?
There was a problem hiding this comment.
First of all: (Where) Do you actually plan to pass a DB into your new function?
There was a problem hiding this comment.
I don't have any (yet), I was just trying to say that it's not that special and one can use it anywhere else if they need to.
There was a problem hiding this comment.
For me the last insert ID makes only sense for immediate subsequent processing – which just screams transaction. So I'd just allow Tx as parameter for now unless/until someone finds an actual use case with DB. (But then I'd:
- unexport the interface OR
- aggregate there all interfaces and non-interface methods both Tx and DB implement.)
| } | ||
| } | ||
|
|
||
| // InsertObtainID executes the given query and fetches the last inserted ID. |
There was a problem hiding this comment.
... here due to how special it is.
yhabteab
force-pushed
the
icinga-notifications
branch
from
89805fa to
b9e7928
Compare
yhabteab
force-pushed
the
icinga-notifications
branch
from
b9e7928 to
7a11e5d
Compare
lippserd
left a comment
lippserd
left a comment
There was a problem hiding this comment.
Please split pr the into two.
|
The commits are split into their own PRs so that this is no longer necessary. |
No description provided.