Silence compiler warnings about unused parameters

[Al2Klimov]

Every of these parameters exists for a reason.
The best we can do is to convince the compiler.

[Al2Klimov]

Let's be honest to each other, this is ultima ratio. Everything which can be fixed in a different way, should be:

• Stream#Read(): remove de facto unused param allow_partial #9736
• Remove unused Stream#Peek() #9734
• Don't define/use OpenSSL*Callback() for/in OpenSSL > v1.1 #9730
• Fix compiler warnings by removing unused variables #9729
• Fix compiler warnings #9411

[jschmidt-icinga]

Sorry for leaving this lying around again, but I had what I thought was an open review comment (but which was "pending" and never sent) and then forgot about it. Can you rebase this again, then I'll approve it?

[jschmidt-icinga]

According to the alpine:bash runner there's more unused parameter warnings not yet fixed in this PR, likely because they were added in the meantime.

[jschmidt-icinga]

You probably only looked at the ones in the "Annotations" widget at the top, but that's limited to 10 results. There's still a few more if you look into the build output:

virtual icinga::Value StatusTargetProvider::GetTargetByName(const icinga::String&, const icinga::String&) const
virtual icinga::String StatusTargetProvider::GetPluralName(const icinga::String&) const
virtual bool icinga::StatusHandler::HandleRequest(const Ptr&, const icinga::HttpRequest&, icinga::HttpResponse&, boost::asio::yield_context&)

virtual bool icinga::TemplateQueryHandler::HandleRequest(const Ptr&, const icinga::HttpRequest&, icinga::HttpResponse&, boost::asio::yield_context&)

virtual void TypeTargetProvider::FindTargets(const icinga::String&, const std::function<void(const icinga::Value&)>&) const
virtual icinga::Value TypeTargetProvider::GetTargetByName(const icinga::String&, const icinga::String&) const
virtual icinga::String TypeTargetProvider::GetPluralName(const icinga::String&) const
virtual bool icinga::TypeQueryHandler::HandleRequest(const Ptr&, const icinga::HttpRequest&, icinga::HttpResponse&, boost::asio::yield_context&)

virtual void VariableTargetProvider::FindTargets(const icinga::String&, const std::function<void(const icinga::Value&)>&) const
virtual icinga::Value VariableTargetProvider::GetTargetByName(const icinga::String&, const icinga::String&) const
virtual icinga::String VariableTargetProvider::GetPluralName(const icinga::String&) const
virtual bool icinga::VariableQueryHandler::HandleRequest(const icinga::WaitGroup::Ptr&, const icinga::HttpRequest&, icinga::HttpResponse&, boost::asio::yield_context&)

static icinga::Downtime::Ptr icinga::Downtime::AddDowntime(const icinga::Checkable::Ptr&, const icinga::String&, const icinga::String&, double, double, bool, const Ptr&, double, const icinga::String&, const icinga::String&, const icinga::String&, const icinga::String&, const icinga::MessageOrigin::Ptr&)

[jschmidt-icinga]

Still missed one: origin in Downtime::Ptr Downtime::AddDowntime(). I see.

And sorry, now there's merge conflicts too (my fault 🙈).