Open
Conversation
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
89b5572 to
df87d2b
Compare
sukhwinder33445
previously approved these changes
Dec 5, 2025
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
The code looks good, @Jan-Schuppik, please approve it when the UI tests are also fine.
sukhwinder33445
previously approved these changes
Dec 5, 2025
Jan-Schuppik
previously approved these changes
Dec 8, 2025
BastianLedererIcinga
dismissed stale reviews from Jan-Schuppik and sukhwinder33445
via
f835d14
lippserd
requested changes
Jan 15, 2026
| { | ||
| $column = $condition->metaData()->get('columnName'); | ||
| if (! isset($this->properties[$column])) { | ||
| if (! isset($column) || ! isset($this->properties[$column])) { |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
f835d14 to
3da67a7
Compare
Member
|
@BastianLedererIcinga Please rebase. |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
3da67a7 to
e52cab5
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
e52cab5 to
4588690
Compare
Closed
Implcitly nullable parameters are deprecated since PHP-8.4 typed parameters that default to null must include `null` in their type
The method has no effect since php 8.1 and is deprecated in php 8.5
The constant is deprecated since php-8.5 but the replacement `Pdo\Mysql::ATTR_INIT_COMMAND` is only available since php-8.4
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
bfa33e3 to
6b83442
Compare
Passing `null` as `$key` to `array_key_exists()` or using it as an array key is deprecated since php-8.5
Errors that were no longer reported have been removed, keeping them in the baseline could hide future errors.
Since PHP 7.x is no longer supported the 7.x baseline is removed and it is no longer necessary have multiple baseline files.
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
6b83442 to
7771483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that had to be addressed
PHP 8.3 -> PHP 8.4
Migration docs: https://www.php.net/manual/en/migration84
PHP 8.4 -> PHP 8.5
Migration Docs: https://www.php.net/manual/en/migration85
instead of PDO::SQL<constant_name> use Pdo\Mysql::<constant_name>.
$keyparameter toarray_key_exists()is deprecatedresolves: #1312