Skip to content

fix(file-input): make all elements styleable with CSS variables + fix Bootstrap invalid box-shadow#1747

Merged
simeonoff merged 17 commits intomasterfrom
apetrov/add-file-input-css-vars
Jul 4, 2025
Merged

fix(file-input): make all elements styleable with CSS variables + fix Bootstrap invalid box-shadow#1747
simeonoff merged 17 commits intomasterfrom
apetrov/add-file-input-css-vars

Conversation

@adrianptrv
Copy link
Contributor

Closes #1676

This PR is related to the fix: #439

I have added CSS variables for parts of the file-input that couldn't be styled individually before, using only variables.
I also fixed the box-shadow of the Bootstrap invalid state on the file-input, input, select, and textarea components so that it only appears when the component is focused, and not all the time.

@adrianptrv adrianptrv requested a review from simeonoff June 14, 2025 14:45
@adrianptrv adrianptrv changed the title make all file-input elements stylable with CSS variables + fix Bootstrap invalid box-shadow fix(file-input): make all file-input elements stylable with CSS variables + fix Bootstrap invalid box-shadow Jun 14, 2025
@desig9stein
Copy link
Contributor

desig9stein commented Jul 2, 2025

When I change the filename background, the input looks like this.

Screenshot 2025-07-02 at 11 23 00

Is this the expected behavior?

To change the entire background of the file input, I need to modify the box-background variable, which is part of the input-group, to match the file-name-background, which is part of the file type.

Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are changes being made to the select and textearea themes in this PR?


:host(:is(igc-file-input)) {
[part~='file-names'] {
color: var(--ig-file-names-foreground, #000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this come from the $theme? I see this repeated in all files and it doesn't sit right.

@simeonoff
Copy link
Collaborator

When I change the filename background, the input looks like this.

Screenshot 2025-07-02 at 11 23 00 Is this the expected behavior?

To change the entire background of the file input, I need to modify the box-background variable, which is part of the input-group, to match the file-name-background, which is part of the file type.

You are changing the file names background so it looks correct to me.

@simeonoff simeonoff changed the title fix(file-input): make all file-input elements stylable with CSS variables + fix Bootstrap invalid box-shadow fix(file-input): make all elements styleable with CSS variables + fix Bootstrap invalid box-shadow Jul 4, 2025
@simeonoff
Copy link
Collaborator

@desig9stein Can you verify the PR please?

@simeonoff simeonoff merged commit ca6fc20 into master Jul 4, 2025
5 checks passed
@simeonoff simeonoff deleted the apetrov/add-file-input-css-vars branch July 4, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[file input] - has wrong validation styles in bootstrap theme and unable to style many of the elements using CSS vars

3 participants