-
Notifications
You must be signed in to change notification settings - Fork 10
fix(file-input): make all elements styleable with CSS variables + fix Bootstrap invalid box-shadow #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix(file-input): make all elements styleable with CSS variables + fix Bootstrap invalid box-shadow #1747
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ae67b29
feat(file-input): fix bootstrap invalid state box-shadow + add file-i…
adrianptrv 1fc4ecb
Merge branch 'master' into apetrov/add-file-input-css-vars
adrianptrv 5063b84
fix(file-input): lint errors
adrianptrv d659f3b
Merge branch 'master' into apetrov/add-file-input-css-vars
simeonoff 90bc2a9
Merge branch 'master' into apetrov/add-file-input-css-vars
desig9stein 5181b60
fix(file-input): change token names to past tense
adrianptrv b25d555
Merge branch 'master' into apetrov/add-file-input-css-vars
adrianptrv 1dfe684
Merge branch 'master' into apetrov/add-file-input-css-vars
desig9stein e787b74
feat(file-input): add foreground tokens for file names field
adrianptrv d82b334
Merge branch 'master' into apetrov/add-file-input-css-vars
adrianptrv a7f4127
Merge branch 'master' into apetrov/add-file-input-css-vars
simeonoff c7fc55c
Merge branch 'master' into apetrov/add-file-input-css-vars
desig9stein 6762000
chore(theming): bump to 19.1.0
adrianptrv 38ac30d
Merge branch 'master' into apetrov/add-file-input-css-vars
desig9stein db6817b
Merge branch 'master' into apetrov/add-file-input-css-vars
simeonoff 3952e03
deps(theming): bump to latest version
simeonoff 935b521
fix(file-input): remove individual file-name selectors (fix comment)
adrianptrv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| @use 'sass:map'; | ||
| @use 'styles/utilities' as *; | ||
| @use 'igniteui-theming/sass/themes/schemas/components/dark/file-input' as *; | ||
|
|
||
| $material: digest-schema($dark-material-file-input); | ||
| $bootstrap: digest-schema($dark-bootstrap-file-input); | ||
| $fluent: digest-schema($dark-fluent-file-input); | ||
| $indigo: digest-schema($dark-indigo-file-input); |
9 changes: 9 additions & 0 deletions
9
src/components/file-input/themes/dark/file-input.bootstrap.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
| @use '../light/themes' as light; | ||
|
|
||
| $theme: $bootstrap; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff(light.$base, $theme), 'ig'); | ||
| } |
15 changes: 15 additions & 0 deletions
15
src/components/file-input/themes/dark/file-input.fluent.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
| @use '../light/themes' as light; | ||
|
|
||
| $theme: $fluent; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff(light.$base, $theme), 'ig'); | ||
| } | ||
|
|
||
| :host(:is(igc-file-input)) { | ||
| [part~='file-names'] { | ||
| color: var(--ig-file-names-foreground, #fff) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
| @use '../light/themes' as light; | ||
|
|
||
| $theme: $indigo; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff(light.$base, $theme), 'ig'); | ||
| } |
15 changes: 15 additions & 0 deletions
15
src/components/file-input/themes/dark/file-input.material.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
| @use '../light/themes' as light; | ||
|
|
||
| $theme: $material; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff(light.$base, $theme), 'ig'); | ||
| } | ||
|
|
||
| :host(:is(igc-file-input)) { | ||
| [part~='file-names'] { | ||
| color: var(--ig-file-names-foreground, #fff) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| @use 'sass:map'; | ||
| @use 'styles/utilities' as *; | ||
| @use 'igniteui-theming/sass/themes/schemas/components/light/file-input' as *; | ||
|
|
||
| $base: digest-schema($light-file-input); | ||
| $material: digest-schema($material-file-input); | ||
| $bootstrap: digest-schema($bootstrap-file-input); | ||
| $fluent: digest-schema($fluent-file-input); | ||
| $indigo: digest-schema($indigo-file-input); |
8 changes: 8 additions & 0 deletions
8
src/components/file-input/themes/light/file-input.bootstrap.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
|
|
||
| $theme: $bootstrap; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff($base, $theme), 'ig'); | ||
| } |
14 changes: 14 additions & 0 deletions
14
src/components/file-input/themes/light/file-input.fluent.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
|
|
||
| $theme: $fluent; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff($base, $theme), 'ig'); | ||
| } | ||
|
|
||
| :host(:is(igc-file-input)) { | ||
| [part~='file-names'] { | ||
| color: var(--ig-file-names-foreground, #000) | ||
| } | ||
| } | ||
8 changes: 8 additions & 0 deletions
8
src/components/file-input/themes/light/file-input.indigo.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
|
|
||
| $theme: $indigo; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff($base, $theme), 'ig'); | ||
| } |
14 changes: 14 additions & 0 deletions
14
src/components/file-input/themes/light/file-input.material.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
|
|
||
| $theme: $material; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme(diff($base, $theme), 'ig'); | ||
| } | ||
|
|
||
| :host(:is(igc-file-input)) { | ||
| [part~='file-names'] { | ||
| color: var(--ig-file-names-foreground, #000) | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
src/components/file-input/themes/light/file-input.shared.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use 'themes' as *; | ||
|
|
||
| :host { | ||
| @include css-vars-from-theme($base, 'ig'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
src/components/file-input/themes/shared/file-input.indigo.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| @use 'styles/utilities' as *; | ||
| @use '../../../input/themes/light/themes' as *; | ||
| @use '../light/themes' as file-input; | ||
|
|
||
| $theme: $indigo; | ||
| $theme-file-input: file-input.$indigo; | ||
|
|
||
| [part='file-names'] { | ||
| @include type-style('body-2'); | ||
|
|
||
| color: var-get($theme, 'idle-text-color'); | ||
| color: var-get($theme-file-input, 'file-names-foreground'); | ||
| font-size: rem(12px); | ||
| line-height: rem(16px); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this come from the $theme? I see this repeated in all files and it doesn't sit right.