Add new field type for logical values#230
Merged
jacobcook1995 merged 4 commits intodevelopfrom Jan 12, 2026
Merged
Conversation
jacobcook1995
commented
Jan 12, 2026
docs/data_managers/command_line_tools/command_line_usage/safedata_metadata_top.txt
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
+ Coverage 81.12% 81.28% +0.15%
===========================================
Files 14 14
Lines 3544 3558 +14
===========================================
+ Hits 2875 2892 +17
+ Misses 669 666 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
25dc120 to
f76f75c
Compare
davidorme
approved these changes
Jan 12, 2026
Collaborator
davidorme
left a comment
There was a problem hiding this comment.
That all looks very clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new field type for logical values (i.e. cases where data can be either true or false).
Code changes are minimal (because I could follow the existing pattern), but do need to be sanity checked
I've also added description of this new field type to the docs, which I could do with some feedback on.